Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jonathan Bakker <xc-racer2@live.ca>
Subject: Re: [PATCH v2] Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading
Date: Wed, 19 Dec 2018 00:49:49 +0100	[thread overview]
Message-ID: <6E62E2F9-5754-40AA-BA19-CDDABF338A1B@holtmann.org> (raw)
In-Reply-To: <20181205212232.3947-1-pawel.mikolaj.chmiel@gmail.com>

Hi Pawel,

> The Broadcom controller on aries S5PV210 boards sends out a couple of
> unknown packets after the firmware is loaded.  This will cause
> logging of errors such as:
> 	Bluetooth: hci0: Frame reassembly failed (-84)
> 
> This is probably also the case with other boards, as there are related
> Android userspace patches for custom ROMs such as
> https://review.lineageos.org/#/c/LineageOS/android_system_bt/+/142721/
> Since this appears to be intended behaviour, treated them as diagnostic
> packets.
> 
> Note that this is another variant of commit 01d5e44ace8a
> ("Bluetooth: hci_bcm: Handle empty packet after firmware loading")
> 
> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> 
> ---
> Changes from v1:
> 	- Rename UNKNOWN to TYPE49
> 	- Rename UNKNOWN2 to TYPE52
> ---
> drivers/bluetooth/hci_bcm.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)

can you update this patch against latest bluetooth-next tree since it no longer applies cleanly.

Regards

Marcel


  reply	other threads:[~2018-12-18 23:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05 21:22 [PATCH v2] Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading Paweł Chmiel
2018-12-18 23:49 ` Marcel Holtmann [this message]
2018-12-19 11:26   ` Paweł Chmiel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6E62E2F9-5754-40AA-BA19-CDDABF338A1B@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pawel.mikolaj.chmiel@gmail.com \
    --cc=xc-racer2@live.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox