From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr() From: Marcel Holtmann In-Reply-To: <20170722211658.fdfcwoqshtrxqvwj@earth> Date: Sun, 23 Jul 2017 09:32:23 +0200 Cc: linux-bluetooth@vger.kernel.org Message-Id: <6FFF415F-F875-481B-A6D6-3DD7159C7DDD@holtmann.org> References: <20170722095747.101069-1-marcel@holtmann.org> <20170722190323.mt5mrnioql7z2uj2@earth> <20170722211658.fdfcwoqshtrxqvwj@earth> To: Sebastian Reichel Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Sebastian, >>>> The Nokia devices require the setup of its Public Bluetooth Device >>>> Address and for that it is required to depend on vendor specific >>>> commands. For Broadcom based Nokia devices, that is part of btbcm >>>> module and can be selected via BT_BCM config option. >>>> >>>> Signed-off-by: Marcel Holtmann >>> >>> Reviewed-by: Sebastian Reichel >> >> btw. we need to also provide the set_bdaddr for TI chips. > > The TI based chip in Nokia N950 has a proper address configured, so > it works without set_bdaddr (it would still be nice of course). It > also seems to be missing for hci_ll, though. So the required command > is completly unknown? are these a TI address or a Nokia address? I doubt Nokia would have actually shipped any hardware using an IEEE assigned address to TI. Where do we have the firmware files for the Nokia devices? Don't they contain a command for setting the BD_ADDR. Also the original Nokia driver had code to re-write that command inline while loading the firmware. Regards Marcel