Re: [PATCH 1/2] Bluetooth: btintel: Fix spurious error on FW download error recovery

[Ameen Al-Asady <ameenaladdin@gmail.com>]

Hi Paul,

Thanks for the review.

> "fail" is ambiguous to me. Maybe "errors out".

Reworded in v2.

> Any hint how to match the firmware versions, or add a sentence what
> firmware is on the controller and which one is downloaded?

Added the firmware build lines to the log excerpt in v2. The
controller was running build 81755 (2024.33) and the file on disk
contained build 82122 (2026.5).

> Please mention the system you tested this on.

Done. Tested on an Intel AX210 (USB 8087:0032) on a 7.1.3 kernel by
rebinding btusb with a non-matching firmware file on disk, in both
the downgrade and upgrade direction. Both runs took the -ENODEV path,
logged the info message instead of the error and completed the
download after re-enumeration.

> Excuse my ignorance, but moving kfree_skb to a new else branch is
> not totally clear to me.

When __hci_cmd_sync() fails it returns an error pointer instead of a
real skb, so there is nothing to free. kfree_skb() must only run in
the success case, which is now the else branch. The old code had the
same behavior through the early return.

v2 sent.

Regards,
Ameen