Re: [PATCH v2] Bluetooth: mediatek: add gpio pin to reset bt

[Krzysztof Kozlowski <krzk@kernel.org>]

On 12/06/2025 09:22, Zhangchao Zhang wrote:
> This V2 patch provides two methods btmtk_reset_by_gpio,
> btmtk_reset_by_gpio_work for mediatek controller,
> it has been tested locally many times and can reset normally.
> 
> The pin is configured in dts files, bluetooth is reset by pulling
> the pin, when exception or coredump occurs, the above methods will
> be used to reset the bluetooth, if the pin is not found, it also can
> reset bluetooth successfully by software reset.
> 
> Compared with the previously submitted version, the following
> information has been revised in version V2
> 1)-Changed the capitalization of co-developer names,
>    using the correct capitalization of abbreviations and full
>    name, and corrected obvious spelling errors.
> 2)-Add a revision history.
> 3)-Remove the "BT Driver" in the prefix.
> 4)-Add the bt-binding document, include inforamtion related to reset
>    pin and compatibility matching.
> 5)-Add a comment before the schedule_delayed_work function call,
>    although schedule_delayed_work is asynchronous, there is no risk.
>    Even if it is not completed within 200ms, it will only postpone
>    the subsequent probe and will not have any impact.
> 6-)Add a comment before the btmtk_reset_by_gpio function call,
>    if the compatibility filed or pin cannot be found in the dts
>    files, it can still reset bluetooth using software reset.
> 
> Co-developed-by Hao Qin <hao.qin@mediatek.com>
> Co-developed-Chris Lu <chris.lu@mediatek.com>
> Co-developed-Jiande Lu <jiande.lu@mediatek.com>
> Signed-off-by: Zhangchao Zhang <ot_zhangchao.zhang@mediatek.com>

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>


Best regards,
Krzysztof