public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: "An, Tedd" <tedd.an@intel.com>
To: "Gix, Brian" <brian.gix@intel.com>,
	"linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>
Cc: "hj.tedd.an@gmail.com" <hj.tedd.an@gmail.com>
Subject: Re: [PATCH BlueZ] tools: Fix mesh-tester to expect end of ADV
Date: Tue, 27 Sep 2022 23:37:41 +0000	[thread overview]
Message-ID: <72f0133e435ae22c13457b1a902b974b3770e2af.camel@intel.com> (raw)
In-Reply-To: <20220927225514.278400-1-brian.gix@intel.com>

Hi Brian,

I tested on my local machine and not able to reproduce the issue after applying this patch.

Tested-by: Tedd Ho-Jeong An <tedd.an@intel.com>


On Tue, 2022-09-27 at 15:55 -0700, Brian Gix wrote:
> Tester was failing by not clearing the HCI queue of expected events
> ---
>  tools/mesh-tester.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/tools/mesh-tester.c b/tools/mesh-tester.c
> index 6781bd565..d7b3b6f9b 100644
> --- a/tools/mesh-tester.c
> +++ b/tools/mesh-tester.c
> @@ -1345,6 +1345,10 @@ static const uint8_t send_mesh_cancel_2[] = {
>         0x02
>  };
>  
> +static const uint8_t mesh_cancel_rsp_param_mesh[] = {
> +       0x00
> +};
> +
>  static const struct generic_data mesh_send_mesh_cancel_1 = {
>         .send_opcode = MGMT_OP_MESH_SEND_CANCEL,
>         .send_param = send_mesh_cancel_1,
> @@ -1353,6 +1357,10 @@ static const struct generic_data mesh_send_mesh_cancel_1 = {
>         .expect_alt_ev = MGMT_EV_MESH_PACKET_CMPLT,
>         .expect_alt_ev_param = send_mesh_cancel_1,
>         .expect_alt_ev_len = sizeof(send_mesh_cancel_1),
> +
> +       .expect_hci_command = BT_HCI_CMD_LE_SET_ADV_ENABLE,
> +       .expect_hci_param = mesh_cancel_rsp_param_mesh,
> +       .expect_hci_len = sizeof(mesh_cancel_rsp_param_mesh),
>  };
>  
>  static const struct generic_data mesh_send_mesh_cancel_2 = {
> @@ -1363,6 +1371,10 @@ static const struct generic_data mesh_send_mesh_cancel_2 = {
>         .expect_alt_ev = MGMT_EV_MESH_PACKET_CMPLT,
>         .expect_alt_ev_param = send_mesh_cancel_2,
>         .expect_alt_ev_len = sizeof(send_mesh_cancel_2),
> +
> +       .expect_hci_command = BT_HCI_CMD_LE_SET_ADV_ENABLE,
> +       .expect_hci_param = mesh_cancel_rsp_param_mesh,
> +       .expect_hci_len = sizeof(mesh_cancel_rsp_param_mesh),
>  };
>  
>  static void setup_multi_mesh_send(const void *test_data)

Regards,
Tedd Ho-Jeong An


  reply	other threads:[~2022-09-27 23:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27 22:55 [PATCH BlueZ] tools: Fix mesh-tester to expect end of ADV Brian Gix
2022-09-27 23:37 ` An, Tedd [this message]
2022-09-28  0:14 ` [BlueZ] " bluez.test.bot
2022-09-28 13:50 ` [PATCH BlueZ] " patchwork-bot+bluetooth
2022-09-28 17:26 ` Gix, Brian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72f0133e435ae22c13457b1a902b974b3770e2af.camel@intel.com \
    --to=tedd.an@intel.com \
    --cc=brian.gix@intel.com \
    --cc=hj.tedd.an@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox