Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] android/gatt: Fix wrong check
Date: Fri, 13 Jun 2014 16:44:55 +0200	[thread overview]
Message-ID: <7464350.jhI9E2pFpN@uw000953> (raw)
In-Reply-To: <1402569654-27092-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>

Hi Andrei,

On Thursday 12 of June 2014 13:40:54 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> 
> ---
>  android/gatt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/android/gatt.c b/android/gatt.c
> index cc3746c..8da77d0 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -4133,8 +4133,8 @@ static void fill_gatt_response_by_handle(uint16_t handle, uint16_t offset,
>  
>  	entry = queue_find(dev->pending_requests, match_dev_request_by_handle,
>  							UINT_TO_PTR(handle));
> -	if (entry) {
> -		DBG("No pending response found! Bogus android response?");
> +	if (!entry) {
> +		error("No pending response found! Bogus android response?");
>  		return;
>  	}

I've already pushed similar fix from Marcin. But please rebase and send
DBG to error change.

-- 
Best regards, 
Szymon Janc

  reply	other threads:[~2014-06-13 14:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12 10:40 [PATCH] android/gatt: Fix wrong check Andrei Emeltchenko
2014-06-13 14:44 ` Szymon Janc [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-06-12  9:58 Andrei Emeltchenko
2014-06-12 10:08 ` Marcel Holtmann
2014-06-12 10:40   ` Andrei Emeltchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7464350.jhI9E2pFpN@uw000953 \
    --to=szymon.janc@tieto.com \
    --cc=Andrei.Emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox