public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Swyter <swyterzone@gmail.com>
To: luiz.dentz@gmail.com
Cc: Jack <ostroffjh@users.sourceforge.net>,
	linux-bluetooth@vger.kernel.org,
	Paul Menzel <pmenzel@molgen.mpg.de>,
	Marcel Holtmann <marcel@holtmann.org>,
	Hans de Goede <hdegoede@redhat.com>,
	swyterzone@gmail.com
Subject: Re: [Regression] Cambridge Silicon Radio, Ltd Bluetooth Dongle
Date: Wed, 9 Nov 2022 20:12:52 +0100	[thread overview]
Message-ID: <76cd4547-a68d-9d52-1d87-8299e29406ff@gmail.com> (raw)
In-Reply-To: <CABBYNZKWc13qGDOyhPZ9wZcTaK+Wg0LUycsKX58w7wEjTaGS=A@mail.gmail.com>

>> Correct hci_set_event_mask_page_2_sync() event mask
>> git bisect good 0feb8af0275d196a29e321bedc15319673923cb6
>> # bad: [1172c59f451f524a14bac5e7b047781883dfe441] Bluetooth: btusb:
>> Remove HCI_QUIRK_BROKEN_ERR_DATA_REPORTING for QCA
>> git bisect bad 1172c59f451f524a14bac5e7b047781883dfe441
>> # bad: [766ae2422b4312a73510ebee9266bc23b466fbbb] Bluetooth: hci_sync:
>> Check LMP feature bit instead of quirk
>> git bisect bad 766ae2422b4312a73510ebee9266bc23b466fbbb
>> # first bad commit: [766ae2422b4312a73510ebee9266bc23b466fbbb]
>> Bluetooth: hci_sync: Check LMP feature bit instead of quirk
>>
>> And 766ae2422b4312a73510ebee9266bc23b466fbbb does make sense as a
>> likely culprit.
> 
> Looks like we will need to reintroduce the quirk then since it appears
> the LMP feature bit is probably set in those controllers but the
> command doesn't work.

It is. I already mentioned it in the Bugzilla thread and that's
what the patch series I submitted the other day fixes:

> Bluetooth: btusb: Fix Chinese CSR dongles again by re-adding ERR_DATA_REPORTING quirk
> https://patchwork.kernel.org/project/bluetooth/patch/20221029202454.25651-1-swyterzone@gmail.com/

Hans de Goede gave it a Reviewed-by, but it has been ignored even since.

Keep in mind that I'm an occasional contributor and I can barely use a mailing list,
but this goes back to the patch that Zijun Hu sent back in July and I was pinged.


I took a look back then, it looked suspect, but I imagined you guys knew what you were
doing. Fast-forward three months and the code arrives at most mainstream distros.

Every single cheap Bluetooth dongle on Earth broke again. Just like that.

https://bugzilla.kernel.org/show_bug.cgi?id=60824#c242

I just came across this thread archive by pure chance, this isn't very user friendly.
Please CC me if you talk about this, I'm not subscribed to any list.

  parent reply	other threads:[~2022-11-09 19:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24 21:11 [Regression] Cambridge Silicon Radio, Ltd Bluetooth Dongle unusable again with kernel 6.0 Jack
2022-10-25  7:02 ` Paul Menzel
2022-10-25 18:00   ` Jack
2022-10-25 19:38     ` Luiz Augusto von Dentz
2022-10-26  3:41       ` quic_zijuhu
2022-10-27  9:48         ` quic_zijuhu
2022-11-09 19:12       ` Swyter [this message]
2022-11-09 19:40         ` [Regression] Cambridge Silicon Radio, Ltd Bluetooth Dongle Jack
2022-11-09 20:43           ` Luiz Augusto von Dentz
2022-11-09 21:14             ` Swyter
2022-11-15  6:20               ` Mika Laitio
2022-11-15  6:41                 ` Swyter
2022-10-26  9:17 ` [Regression] Cambridge Silicon Radio, Ltd Bluetooth Dongle unusable again with kernel 6.0 #forregzbot Thorsten Leemhuis
2022-12-01 14:41   ` Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76cd4547-a68d-9d52-1d87-8299e29406ff@gmail.com \
    --to=swyterzone@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=ostroffjh@users.sourceforge.net \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox