Re: [PATCH 2/2] Bluetooth: hci_bcm: Add support for BCM2E7E

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 04-10-17 21:07, Marcel Holtmann wrote:
> Hi Hans,
> 
>>>> This will happen automatically with this patch series,
>>>> but with the current 4.14 bluetooth stack it will work in
>>>> USB mode, and if we then merge this series post 4.14
>>>> bluetooth will stop working without users doing a btattach
>>>> command from userspace and we will have a regression on
>>>> our hands.
>>> Once the series from Frédéric Danis lands, you can get
>>> serial based broadcom bluetooth without btattach:
>>> https://www.spinics.net/lists/linux-bluetooth/msg71856.html
>>
>> Oh, cool. Thank you for pointing this out to me. I still
>> believe reverting the workaround for the 0000:0000
>> usb-id device is the right thing to do though.
>>
>> I've tested Frédéric Danis' series and it needed quite
>> some work on one of my devices. I've just submitted
>> a 9 patch series to add all the features the platform
>> code paths of hci_bcm.c have and which were missing from
>> the serdev code paths.
> 
> can you send a revert patch with a proper commit message explaining why we are reverting it and then I take it in with your other patch series.

Hmm, I thought I had already send that? But I cannot find it
in the archives, so it looks like I prepared it but never
send it...

I've send it out now, it would be nice to get the revert
into 4.14 so that we don't end up with one kernel release
where we do support the 0000:0000 usb-id.

Regards,

Hans