From: Szymon Janc <szymon.janc@tieto.com>
To: Marcin Kraglak <marcin.kraglak@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/4] android/gatt: Remove unneeded label from unregister_client
Date: Fri, 11 Apr 2014 15:54:55 +0200 [thread overview]
Message-ID: <7987899.aG6gJZyyB9@uw000953> (raw)
In-Reply-To: <1397155238-8578-1-git-send-email-marcin.kraglak@tieto.com>
Hi Marcin,
On Thursday 10 of April 2014 20:40:35 Marcin Kraglak wrote:
> ---
> android/gatt.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index a7a7204..4a720cc 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -506,13 +506,11 @@ static void handle_client_unregister(const void *buf, uint16_t len)
> if (!cl) {
> error("gatt: client_if=%d not found", cmd->client_if);
> status = HAL_STATUS_FAILED;
> - goto failed;
> + } else {
> + destroy_gatt_client(cl);
> + status = HAL_STATUS_SUCCESS;
> }
>
> - destroy_gatt_client(cl);
> - status = HAL_STATUS_SUCCESS;
> -
> -failed:
> ipc_send_rsp(hal_ipc, HAL_SERVICE_ID_GATT,
> HAL_OP_GATT_CLIENT_UNREGISTER, status);
> }
>
All patches applied. Thanks.
--
Best regards,
Szymon Janc
prev parent reply other threads:[~2014-04-11 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 18:40 [PATCH 1/4] android/gatt: Remove unneeded label from unregister_client Marcin Kraglak
2014-04-10 18:40 ` [PATCH 2/4] android/gatt: Simplify removing device from list Marcin Kraglak
2014-04-10 18:40 ` [PATCH 3/4] android/gatt: Format string with address properly Marcin Kraglak
2014-04-11 13:56 ` Szymon Janc
2014-04-10 18:40 ` [PATCH 4/4] android/gatt: Remove double variable check Marcin Kraglak
2014-04-11 13:54 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7987899.aG6gJZyyB9@uw000953 \
--to=szymon.janc@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcin.kraglak@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox