From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48003EB64DC for ; Mon, 17 Jul 2023 11:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230342AbjGQLZX (ORCPT ); Mon, 17 Jul 2023 07:25:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230244AbjGQLZV (ORCPT ); Mon, 17 Jul 2023 07:25:21 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A27FDE58 for ; Mon, 17 Jul 2023 04:25:12 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3fbc244d307so44441765e9.1 for ; Mon, 17 Jul 2023 04:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689593111; x=1692185111; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5Ys1YN2HOQPJOEjXN2Csu3md0LswG0ZSrzC1ZYuVgkU=; b=R5NPDI6zbqhzkhZaXbu1D6Lnni6a89Z2vr7sySP/graqSVqAte7SS3M/rcmoPa5p1u s353AmKlRE1g9Vjny40WxOCSBI/t0qQuxXK3n1Cj6LL3RsoxbDJJJSng4R6rq6MCKZnr y6o7kA8Rdh0fCLEptcjaFY6jfe/ypeS8eEwzNUaPCbEGANzUbGWMV3+G0mfg+vgdn/TZ 7KWkZolmbGLW0DBKcsCJnwtOCWbFPXXzQZi4FhcWWqnGJ/hsCNyvo0yn+BpWIPhQ/D3K 8qbkBwhUNtjokCaKNvJEHIv4hsZVqaRk7lCUh/Jn7VjskQEBOvMwKTZmcZ/2AmqqsOwQ 0irg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689593111; x=1692185111; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5Ys1YN2HOQPJOEjXN2Csu3md0LswG0ZSrzC1ZYuVgkU=; b=dAYlO54DGyqZyixXgkfzI/Nw2cwUalt3VZ21tFcwqUeYKGVenOxyoWSjEs85dRhReD PQz6aLEyK8n7AzunbBLgb0TAjJUWhSrUU9dZC3vyqG7zuSNb105jJlE9dRPrZ69Fro21 k5CXUXUUyjqLRAki5XQ65AM2Ir/Q+MTlTmeSxgBeye9WezxpjzF00/wHM0ExRh6AsKWz Uf7u3YjT4wOp4i41qWkt6cFrRiJMFgKj+Q/CGKsDuAGiDlSPl2869X0IyFYO5XlWwmyj KmgNxB5dCK6anB3KRCYhuHoFt/2nNoQZV3tnf8urkOCEK3v9aaZJ0wCQXfZbol/kAnkc n7hw== X-Gm-Message-State: ABy/qLbJeCnM7r9EbbQsNw/Jpv50ADG1fXDXZb0v0YblA+bZZne7keaw qLCAVCJM6kvsBPUKxO0q9MdxDw== X-Google-Smtp-Source: APBJJlHpol2ylHXvu1RA4C+qcwPwHZ9exr9Mc6FepvcBhLgXwr5+sMLw/YyfAhjDrwacLIcI/Y6sTw== X-Received: by 2002:a7b:c7c5:0:b0:3fb:cf8e:c934 with SMTP id z5-20020a7bc7c5000000b003fbcf8ec934mr10093708wmk.27.1689593111086; Mon, 17 Jul 2023 04:25:11 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id n22-20020a7bc5d6000000b003fa968e9c27sm7695338wmk.9.2023.07.17.04.25.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jul 2023 04:25:09 -0700 (PDT) Date: Mon, 17 Jul 2023 14:25:06 +0300 From: Dan Carpenter To: joeyli Cc: Markus Elfring , linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org, Chun-Yi Lee , "David S. Miller" , Johan Hedberg , Marcel Holtmann , LKML Subject: Re: [PATCH] Bluetooth: hci_event: Ignore NULL link key in hci_link_key_notify_evt() Message-ID: <7cc32a46-b4f6-4d92-bf72-24fdbb8f3eca@kadam.mountain> References: <20230714161210.20969-1-jlee@suse.com> <8eeb958e-d947-2f6d-5942-d30746cf1268@web.de> <20230717055150.GO5866@linux-l9pv.suse> <7cae670e-b7c5-470b-536b-ab03513cd0a3@web.de> <20230717102310.GS5866@linux-l9pv.suse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230717102310.GS5866@linux-l9pv.suse> Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Mon, Jul 17, 2023 at 06:23:10PM +0800, joeyli wrote: > Hi Markus, > > On Mon, Jul 17, 2023 at 08:15:56AM +0200, Markus Elfring wrote: > > >> … > > >>> We can ignore null link key in the handler of "Link Key Notification > > >>> event" to relieve the attack. … > > … > > > Sorry for I didn't capture your point. > > > > Did you provide sufficient justification for a possible addition of the tag “Fixes”? > > > > This patch is against a CVE. The issue is not introduced by any old kernel > patch. So I think it doesn't need Fixes: tag. You should probably put a Fixes tag against when the feature was introduced. (Kernel's prior to that were not affected by the CVE). regards, dan carpenter