From: Szymon Janc <szymon.janc@tieto.com>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 4/4] core: Add support for Multi Profile Specification
Date: Sat, 14 Feb 2015 15:51:59 +0100 [thread overview]
Message-ID: <8280430.RqLY9WsdAc@leonov> (raw)
In-Reply-To: <20150214144350.GA9782@t440s.P-661HNU-F1>
Hi Johan,
On Saturday 14 of February 2015 16:43:50 Johan Hedberg wrote:
> Hi Szymon,
>
> On Sat, Feb 14, 2015, Szymon Janc wrote:
> > + str = g_key_file_get_string(config, "General", "MultiProfile", &err);
> > + if (err) {
> > + g_clear_error(&err);
> > + } else {
> > + DBG("MultiProfile=%s", str);
> > +
> > + if (strcmp(str, "mpsd")) {
> > + mps_mpsd = true;
> > + } else if (strcmp(str, "mpmd")) {
> > + mps_mpsd = true;
> > + mps_mpmd = true;
> > + }
>
> Shouldn't these be '!strcmp'?
>
> Johan
They should. I'll send V3 of this patch shortly.
--
BR
Szymon Janc
next prev parent reply other threads:[~2015-02-14 14:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-14 13:02 [PATCH v2 1/4] sdp: Add initial support for MPS Szymon Janc
2015-02-14 13:02 ` [PATCH v2 2/4] sdp: Add support for MPMD in MPS Szymon Janc
2015-02-14 13:02 ` [PATCH v2 3/4] android: Use common MPS implementation Szymon Janc
2015-02-14 13:02 ` [PATCH v2 4/4] core: Add support for Multi Profile Specification Szymon Janc
2015-02-14 14:43 ` Johan Hedberg
2015-02-14 14:51 ` Szymon Janc [this message]
2015-02-14 15:34 ` [PATCH v3 " Szymon Janc
2015-02-14 19:59 ` Marcel Holtmann
2015-02-15 15:43 ` [PATCH v4 " Szymon Janc
2015-02-17 17:31 ` [PATCH v2 1/4] sdp: Add initial support for MPS Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8280430.RqLY9WsdAc@leonov \
--to=szymon.janc@tieto.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).