Re: [PATCH 0/4] Bluetooth: L2CAP: part 2 of l2cap_conn::chan_l locking fixes

[Pauli Virtanen <pav@iki.fi>]

ke, 2026-09-02 kello 00:04 +0300, Pauli Virtanen kirjoitti:
> Rebase to fix conflict in remaining commits from series
> https://lore.kernel.org/linux-bluetooth/cover.1788013041.git.pav@iki.fi/
> 
> Fixed minor conflict vs. moved mutex_lock + l2cap_chan_lock in diff
> context
> commit ddaccd985bb0 ("Bluetooth: L2CAP: fix out-of-bounds write in l2cap_ecred_connect")
> 
> No other changes than resolving that.
> 
> Pauli Virtanen (4):
>   Bluetooth: L2CAP: take lock for l2cap_chan_del in
>     l2cap_ecred_rsp_defer
>   Bluetooth: L2CAP: annotate locking for l2cap_chan_del()
>   Bluetooth: L2CAP: annotate locking for l2cap_ops callbacks

Sashiko report comments that some callbacks in functions in l2cap_ops
are not marked with __must_hold(chan->lock) annotation.

That comment is not correct, e.g. l2cap_chan_send is called from
6lowpan.c and smp.c without holding chan->lock, so the annotations
cannot be added, it'd need solving locking issues first.

>   Bluetooth: L2CAP: refuse __l2cap_chan_add if chan already has conn
> 
>  include/net/bluetooth/l2cap.h |  65 +++++++++++--------
>  net/bluetooth/6lowpan.c       |   2 +
>  net/bluetooth/l2cap_core.c    | 113 ++++++++++++++++++++++++++++++++--
>  net/bluetooth/l2cap_sock.c    |   2 +
>  4 files changed, 150 insertions(+), 32 deletions(-)

-- 
Pauli Virtanen