From: Marcel Holtmann <marcel@holtmann.org>
To: Himangi Saraogi <himangi774@gmail.com>
Cc: "Gustavo F. Padovan" <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] bluetooth/btuart_cs: Remove typedef btuart_info_t
Date: Wed, 13 Aug 2014 10:18:01 -0700 [thread overview]
Message-ID: <845CA98D-39F0-4F2F-8ADF-7DBE1D7BA4ED@holtmann.org> (raw)
In-Reply-To: <20140813092139.GA3189@himangi-Dell>
Hi Himangi,
> The Linux kernel coding style guidelines suggest not using typedefs
> for structure types. This patch gets rid of the typedef for
> btuart_info_t. Also, the name of the struct is changed to drop the _t,
> to make the name look less typedef-like.
>
> The following Coccinelle semantic patch detects the case:
>
> @tn@
> identifier i;
> type td;
> @@
>
> -typedef
> struct i { ... }
> -td
> ;
>
> @@
> type tn.td;
> identifier tn.i;
> @@
>
> -td
> + struct i
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/bluetooth/btuart_cs.c | 27 ++++++++++++++-------------
> 1 file changed, 14 insertions(+), 13 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2014-08-13 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 9:21 [PATCH] bluetooth/btuart_cs: Remove typedef btuart_info_t Himangi Saraogi
2014-08-13 17:18 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=845CA98D-39F0-4F2F-8ADF-7DBE1D7BA4ED@holtmann.org \
--to=marcel@holtmann.org \
--cc=gustavo@padovan.org \
--cc=himangi774@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox