From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24B75C43219 for ; Tue, 22 Nov 2022 16:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233162AbiKVQm6 (ORCPT ); Tue, 22 Nov 2022 11:42:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233976AbiKVQm4 (ORCPT ); Tue, 22 Nov 2022 11:42:56 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 682821C90E; Tue, 22 Nov 2022 08:42:52 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669135370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R1WhU15sqpsop/ukaaUc7gI5zuOdhbblJAEG6t8OCMQ=; b=y6naOLGFvz9Sl3hNhfg5l9yNrEiEy+p4FonO2MrfG9k7XMR08lGTOsywj43cUtfU0LnE3C 1z/dlfqsTuwhJDUYV5Q+J/KdvjrK6UPj7tDDVmMFWFSn9y6ZhtMbMaAT3fD3UYtxbGEzcN HVk2ZFRG41+JrBHQEVWn1bPZgn85dwcK/Q/rEdmreRuaBFdUZZmHOZltTc7E3WscOdNfp8 AECFNaB0pRofNbCIP5kg6Uyjkr9KjBN5oJRwW83/kpQt+3Y3SbMz5R+6Nrlhh/q/8TiZnQ kC6BG2KxPeHrNPWoSN6Rq4pRpA6R/DKRUDhRwuGjBVzzQ6E3LBs/n5Xmh9NH7w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669135370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R1WhU15sqpsop/ukaaUc7gI5zuOdhbblJAEG6t8OCMQ=; b=VNftf6BMJ9EYZyF531LLRIvUW59W4X9URD41xna7lxGvN+xS73oK0xrfl8mQUKKEY5TluR IkFKYFgJhDIv84CQ== To: Steven Rostedt Cc: LKML , Linus Torvalds , Anna-Maria Behnsen , Peter Zijlstra , Stephen Boyd , Guenter Roeck , Andrew Morton , Julia Lawall , Arnd Bergmann , Viresh Kumar , Marc Zyngier , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Jonathan Corbet Subject: Re: [patch 06/15] timers: Update kernel-doc for various functions In-Reply-To: <20221122104124.2f04c7be@gandalf.local.home> References: <20221115195802.415956561@linutronix.de> <20221115202117.323694948@linutronix.de> <20221121154358.36856ca6@gandalf.local.home> <878rk3ggqa.ffs@tglx> <20221122104124.2f04c7be@gandalf.local.home> Date: Tue, 22 Nov 2022 17:42:49 +0100 Message-ID: <8735abgcty.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Tue, Nov 22 2022 at 10:41, Steven Rostedt wrote: > On Tue, 22 Nov 2022 16:18:37 +0100 > Thomas Gleixner wrote: > >> >> + * This function cannot guarantee that the timer cannot be rearmed right >> >> + * after dropping the base lock. That needs to be prevented by the calling >> >> + * code if necessary. >> > > > Also, re-reading it again, I wounder if we can avoid the double use of > "cannot", in "cannot guarantee that the timer cannot". > > What about: > > This function does not prevent the timer from being rearmed right after > dropping the base lock. Funny enough I noticed myself when I copied this sentence into the code and did exactly the same change :)