From: Szymon Janc <szymon.janc@tieto.com>
To: Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] tools/mcaptest: Add missing mainloop quit
Date: Thu, 30 Oct 2014 02:49:06 -0700 (PDT) [thread overview]
Message-ID: <8788486.a4c0tCSBXT@leonov> (raw)
In-Reply-To: <1414507356-7620-1-git-send-email-grzegorz.kolodziejczyk@tieto.com>
Hi Grzegorz,
On Tuesday 28 of October 2014 15:42:36 Grzegorz Kolodziejczyk wrote:
> MCAP test should quit from main loop if mcl disconnects or if can't
> create mdl, mcl. Tested with PTS 5.3 test cases.
> ---
> tools/mcaptest.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/mcaptest.c b/tools/mcaptest.c
> index 5ef030c..dd638c9 100644
> --- a/tools/mcaptest.c
> +++ b/tools/mcaptest.c
> @@ -151,6 +151,8 @@ static void mcl_disconnected(struct mcap_mcl *mcl,
> gpointer data) {
> /* TODO */
> printf("MCL disconnected\n");
> +
> + g_main_loop_quit(mloop);
> }
>
> static void mcl_uncached(struct mcap_mcl *mcl, gpointer data)
> @@ -174,6 +176,7 @@ static void create_mdl_cb(struct mcap_mdl *mcap_mdl,
> uint8_t type, GError *gerr, if (gerr) {
> printf("MDL error: %s\n", gerr->message);
>
> + g_main_loop_quit(mloop);
> return;
> }
>
> @@ -186,6 +189,8 @@ static void create_mdl_cb(struct mcap_mdl *mcap_mdl,
> uint8_t type, GError *gerr, NULL, &err)) {
> printf("Error connecting to mdl: %s\n", err->message);
> g_error_free(err);
> +
> + g_main_loop_quit(mloop);
> }
> }
>
> @@ -255,6 +260,7 @@ static void create_mcl_cb(struct mcap_mcl *mcap_mcl,
> GError *err, gpointer data) if (err) {
> printf("Could not connect MCL: %s\n", err->message);
>
> + g_main_loop_quit(mloop);
> return;
> }
Applied, thanks.
--
BR
Szymon Janc
prev parent reply other threads:[~2014-10-30 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 14:42 [PATCH] tools/mcaptest: Add missing mainloop quit Grzegorz Kolodziejczyk
2014-10-30 9:49 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8788486.a4c0tCSBXT@leonov \
--to=szymon.janc@tieto.com \
--cc=grzegorz.kolodziejczyk@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).