From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Anthony Bourguignon <contact@toniob.net>,
linux-bluetooth@vger.kernel.org
Subject: Re: Can't connect a Xbox one controller
Date: Wed, 24 Aug 2016 11:02:59 -0300 [thread overview]
Message-ID: <87inuqw9gs.fsf@intel.com> (raw)
In-Reply-To: <1471697662.3650.1.camel@toniob.net>
[-- Attachment #1: Type: text/plain, Size: 816 bytes --]
Hi,
Anthony Bourguignon <contact@toniob.net> writes:
>>
>> No. It could be a bug in the xbox controller. But I need to take a
>> closer look at the specification to be really sure.
>
> Can I be of any help ?
Attached is a patch that disables negotiating Flow Control and
Retransmission parameters for the SDP channel only. This is a shot in
the dark, as I could find nothing in the specification that advises
against the current BlueZ behaviour.
Could you give it a try? (but I don't have high hopes for it)
This is looking more like a bug in the controller.
>
> Thanks a lot again
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers,
--
Vinicius
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: disable ertm for SDP --]
[-- Type: text/x-patch, Size: 408 bytes --]
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 54ceb1f..aa078b9 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -3216,6 +3216,9 @@ done:
if (disable_ertm)
break;
+ if (chan->psm == cpu_to_le16(L2CAP_PSM_SDP))
+ break;
+
if (!(chan->conn->feat_mask & L2CAP_FEAT_ERTM) &&
!(chan->conn->feat_mask & L2CAP_FEAT_STREAMING))
break;
next prev parent reply other threads:[~2016-08-24 14:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 10:11 Can't connect a Xbox one controller Anthony Bourguignon
2016-08-18 13:56 ` Luiz Augusto von Dentz
2016-08-18 14:52 ` Anthony Bourguignon
2016-08-18 16:20 ` Luiz Augusto von Dentz
2016-08-18 17:46 ` Anthony Bourguignon
2016-08-19 8:43 ` Luiz Augusto von Dentz
2016-08-19 9:28 ` Anthony Bourguignon
2016-08-19 18:02 ` Vinicius Costa Gomes
[not found] ` <1471642506.3626.5.camel@toniob.net>
2016-08-19 23:34 ` Vinicius Costa Gomes
2016-08-20 12:54 ` Anthony Bourguignon
2016-08-24 14:02 ` Vinicius Costa Gomes [this message]
2017-11-09 13:49 ` Bastien Nocera
2017-11-09 14:28 ` Bastien Nocera
2017-11-09 15:11 ` Bastien Nocera
2017-11-13 10:04 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inuqw9gs.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=contact@toniob.net \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).