From: "Bjørn Mork" <bjorn@mork.no>
To: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix uuid output in debugfs
Date: Wed, 02 Jan 2013 13:37:45 +0100 [thread overview]
Message-ID: <87wqvv92w6.fsf@nemi.mork.no> (raw)
In-Reply-To: <20130102113122.GA22512@x220> (Johan Hedberg's message of "Wed, 2 Jan 2013 13:31:22 +0200")
Johan Hedberg <johan.hedberg@gmail.com> writes:
>> Why can't all this be replaced with
>>
>> static void print_bt_uuid(struct seq_file *f, u8 *uuid)
>> {
>> seq_printf(f, "%pUl\n", uuid);
>> }
>>
>> ?
>
> I don't think there's any reason assuming that there are no unaligned
> access considerations (which I pointed out in my other reply). I wasn't
> aware of printk having such a nice extension to the usual format
> specifiers (and neither was Gustavo as it seems). Thanks for making us
> aware of it!
lib/vsprintf.c:uuid_string() will only access "uuid" byte-by-byte so
alignment shouldn't be a problem.
Bjørn
next prev parent reply other threads:[~2013-01-02 12:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 22:57 [PATCH] Bluetooth: Fix uuid output in debugfs Gustavo Padovan
2013-01-02 9:10 ` Bjørn Mork
2013-01-02 11:31 ` Johan Hedberg
2013-01-02 12:37 ` Bjørn Mork [this message]
2013-01-02 13:43 ` Johan Hedberg
-- strict thread matches above, loose matches on Subject: below --
2012-12-21 22:57 Gustavo Padovan
2012-12-21 22:58 Gustavo Padovan
2013-01-02 9:27 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqvv92w6.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=gustavo.padovan@collabora.co.uk \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).