From: Johan Hedberg <johan.hedberg@gmail.com>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] Crash bug in bluez-4.4
Date: Mon, 8 Sep 2008 22:59:49 +0300 [thread overview]
Message-ID: <8C34E2DC-FBBF-4AE4-9231-171ADE396A3E@gmail.com> (raw)
In-Reply-To: <48C58092.7060103@free.fr>
Hi Fabien,
On Sep 8, 2008, at 22:44, Fabien Chevalier wrote:
> Path attached fixes the bug... by removing three lines of code that
> seem to me not only a premature, but also bogus optimization :-(,
> that prevent us to trying to return the first element of an empty
> gslist.
>
> However i'm not that familiar with that manager stuff and might be
> wrong, so please double check that ;-)
Good catch, and the patch looks good too. Another alternative would
have been to change the return line to
return devices ? devices->data : NULL;
but you're right in that it's just an unnecessary optimization. The
fix is now in the kernel.org git.
Johan
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
prev parent reply other threads:[~2008-09-08 19:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 19:44 [Bluez-devel] Crash bug in bluez-4.4 Fabien Chevalier
2008-09-08 19:59 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8C34E2DC-FBBF-4AE4-9231-171ADE396A3E@gmail.com \
--to=johan.hedberg@gmail.com \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox