From: Marcel Holtmann <marcel@holtmann.org>
To: Rafael J. Wysocki <rjw@sisk.pl>
Cc: David Miller <davem@davemloft.net>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: btusb suspend/resume bug...
Date: Tue, 23 Sep 2008 01:32:05 +0200 [thread overview]
Message-ID: <8C4643EC-E6D9-47D3-8A27-04A2B3CDC6CC@holtmann.org> (raw)
In-Reply-To: <200809222342.46735.rjw@sisk.pl>
Hi Rafael,
>>>> Marcel, others, please bring some kind of closure to this
>>>> regression list entry:
>>>>
>>>> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11442
>>>> Subject : btusb hibernation/suspend breakage in current -git
>>>> Submitter : Rafael J. Wysocki <rjw@sisk.pl>
>>>> Date : 2008-08-25 11:37 (19 days old)
>>>> References : http://marc.info/?l=linux-bluetooth&m=121966402012074&w=4
>>>> Handled-By : Oliver Neukum <oliver@neukum.org>
>>>> Patch : http://marc.info/?l=linux-bluetooth&m=121967226027323&w=4
>>>>
>>>> There is a patch, it is tested, so the only course of action at
>>>> this point is to merge the fix or declare that this really isn't
>>>> a regression.
>>>>
>>>> My impression is the later, because the driver btusb is replacing
>>>> doesn't handle suspend/resume either. Isn't that right?
>>>
>>> the original patch that I had was expecting changes in the USB
>>> subsystem
>>> that I deemed to much at this point. However Oliver got a patch that
>>> would make it work without the USB changes. I am still testing it.
>>>
>>> Let me see if I get some free minutes during the PlumbersConf to get
>>> this fully tested.
>>
>> so I took the patch apart and actually found a few more issues. I
>> am not
>> sure if they should be applied this late in -rc phase.
>>
>> Rafael, can you pull from my tree and test the changes:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/
>> bluetooth-2.6.git
>>
>> It would be interesting if these fixes are enough.
>
> They appear to be enough. I haven't had any suspend/resume failures
> with them
> applied.
so it works _without_ applying patch-btusb-suspend. That would be
great news and mean that there is no bug inside the USB and/or
Bluetooth subsystem. It means we just have a bug when handling the
multiple interfaces. And that makes actually sense.
Dave, I will prepare a minimal patch set for you today or tomorrow.
Regards
Marcel
next prev parent reply other threads:[~2008-09-22 23:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 22:51 btusb suspend/resume bug David Miller
2008-09-17 16:17 ` Marcel Holtmann
2008-09-22 6:24 ` Marcel Holtmann
2008-09-22 21:42 ` Rafael J. Wysocki
2008-09-22 23:32 ` Marcel Holtmann [this message]
2008-09-22 23:33 ` David Miller
2008-09-27 13:41 ` [Bug 11442] " Rafael J. Wysocki
2008-09-30 5:55 ` Marcel Holtmann
2008-09-30 21:44 ` Rafael J. Wysocki
2008-09-30 22:03 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8C4643EC-E6D9-47D3-8A27-04A2B3CDC6CC@holtmann.org \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox