Re: [Bluez-devel] [PATCH] Beautify about dialog

Jaap A. Haitsma
2007-12-17T07:54:51Z

On Dec 17, 2007 8:15 AM, Jaap A. Haitsma <jaap@haitsma.org> wrote:
> On Dec 17, 2007 2:03 AM, Marcel Holtmann <marcel@holtmann.org> wrote:
> > Hi Bastien,
> >
> > > > > > Attached patch does the following
> > > > > >
> > > > > > * about dialog code is simpler
> > > > >
> > > > > you can't use gtk_dialog_run for the applet's about dialog. It will
> > > > > block and thus block all PIN requests. The current code is this way for
> > > > > a reason.
> > > >
> > > > Didn't know that. I now use g_object_set which also reduces the amount
> > > > of code considerably.
> > >
> > > You can still use gtk_show_about_dialog(). It removes the close
> > > callback, and makes sure that only one dialogue shows up, and removes a
> > > lot of boiler-plate code (it doesn't use a separate main loop like
> > > gtk_dialog_run does). The gtk_dialog_run avoidance in the callbacks is
> > > still needed.
> >
> > not sure why I haven't done it that way. Maybe it was not available when
> > I wrote the initial version. However now the requirements are GTK 2.10
> > or later. So if we can simplify code, I am all for it.
> >
> > Regards
> >
> Attached two patches
>
> One uses gtk-show-about-dialog
> The other makes sure that the windows always get an icon
>
Hi

I don't have access to the source code at the moment, but I just
thought of the fact that in gtk-show-about-dialog I set
"program-name". "program-name" got introduced in GTK 2.12, because
"name" was already a property of GtkWidget. So setting "name" does not
give the desired result for GTK >= 2.12 and "program-name" does not
exist in GTK < 2.12

I know of two solutions
1. Don't set program-name or name but just call a
g_set_application_name (_("Bluetooth Applet));
2. Use #ifdef in which you check the version of GTK and depending on
the version you set name or program name

Jaap