Re: [Bluez-devel] [PATCH] Beautify about dialog

Bastien Nocera
2007-12-16T23:24:07Z

Hey Jaap,

On Sun, 2007-12-16 at 23:43 +0100, Jaap A. Haitsma wrote:
> Hi Marcel,
>
> >
> > > Attached patch does the following
> > >
> > > * about dialog code is simpler
> >
> > you can't use gtk_dialog_run for the applet's about dialog. It will
> > block and thus block all PIN requests. The current code is this way for
> > a reason.
>
> Didn't know that. I now use g_object_set which also reduces the amount
> of code considerably.

You can still use gtk_show_about_dialog(). It removes the close
callback, and makes sure that only one dialogue shows up, and removes a
lot of boiler-plate code (it doesn't use a separate main loop like
gtk_dialog_run does). The gtk_dialog_run avoidance in the callbacks is
still needed.

Cheers