Re: [Bluez-devel] [PATCH] Beautify about dialog

Marcel Holtmann
2007-12-17T19:04:25Z

Hi Jaap,

> > > > > > Attached patch does the following
> > > > > >
> > > > > > * about dialog code is simpler
> > > > >
> > > > > you can't use gtk_dialog_run for the applet's about dialog. It will
> > > > > block and thus block all PIN requests. The current code is this way for
> > > > > a reason.
> > > >
> > > > Didn't know that. I now use g_object_set which also reduces the amount
> > > > of code considerably.
> > >
> > > You can still use gtk_show_about_dialog(). It removes the close
> > > callback, and makes sure that only one dialogue shows up, and removes a
> > > lot of boiler-plate code (it doesn't use a separate main loop like
> > > gtk_dialog_run does). The gtk_dialog_run avoidance in the callbacks is
> > > still needed.
> >
> > not sure why I haven't done it that way. Maybe it was not available when
> > I wrote the initial version. However now the requirements are GTK 2.10
> > or later. So if we can simplify code, I am all for it.
> >
> Attached two patches
>
> One uses gtk-show-about-dialog

fix the coding style for this one. I can already see that it messes up
the whitespaces. We use tabs and no whitespace in front of the ( in
function declarations.

> The other makes sure that the windows always get an icon

I applied that patch, but at the same time I applied it to all other
applications inside bluez-gnome. There is more than the applet.

Regards

Marcel