Re: [Bluez-devel] [PATCH] Beautify about dialog

Marcel Holtmann
2007-12-17T00:58:23Z

Hi Jaap,

> > > * about dialog code is simpler
> >
> > you can't use gtk_dialog_run for the applet's about dialog. It will
> > block and thus block all PIN requests. The current code is this way for
> > a reason.
>
> Didn't know that. I now use g_object_set which also reduces the amount
> of code considerably.

I don't think that this makes it any easier to read. The trade a big
block of function with a big big block of properties. Don't see the
advantage in it.

> > > * email address and URLs are clickable
> >
> > Send a separate patch for this.
>
> It's still in the same patch, because the patches change stuff in the
> same function
>
> These two function calls in about_callback do the trick
>
> gtk_about_dialog_set_url_hook (about_dialog_handle_url_cb, NULL, NULL);
> gtk_about_dialog_set_email_hook (about_dialog_handle_email_cb, NULL, NULL);

Then send a patch for it and I can apply it in step. Sending me a big
bunch in one go doesn't make me gonna review it and apply it. Simple
patches go in quicker.

> > > * Makes sure that every window gets a bluetooth window icon
> >
> > This should be already working. And if it is missing somewhere, I need a
> > separate patch for it.
>
> The credits window didn't have it.
>
> The call:
> gtk_window_set_default_icon_name ("stock_bluetooth");
> makes sure that any window at least gets an icon

That is fair enough. Send a patch for it.

> g_set_application_name (_("Bluetooth Applet"));
> makes sure that the about dialog always says "Bluetooth Applet" no
> matter which version of GTK you have installed. (In GTK 2.12 the name
> attribute was changed)

I am against this. I was _not_ using g_set_application_name on purpose,
because I don't see its advantage. If the GTK changes its attributes,
then this is a GTK bug. The GTK 2.x version should be ABI and API
compatible. File a report against GTK 2.12 on this one.

Regards

Marcel