Re: [Bluez-devel] [PATCH] Use new tango icon for bluez gnome

Marcel Holtmann
2008-02-10T17:52:46Z

Hi Jaap,

> > > > > Andreas Nilson has made new tango icons for bluez-gnome. (The
> > > > > stock_bluetooth icon will be removed from gnome-icon-theme, because
> > > > > it's deprecated)
> > > >
> > > > do icons really should belong in the package itself. I was under the
> > > > impression that it is better to have them in a common package and the
> > > > applications are going to reference them only. I am happy to follow the
> > > > GNOME policy here, but someone has to tell me what is the current way to
> > > > go for these.
> > >
> > > The GNOME policy is that only the icons of the icon naming
> > > specification [1] will be in gnome icon theme. Apps have to ship there
> > > own icons.
> >
> > why don't we make the Bluetooth icons then part of the icon naming
> > specification?
> >
>
> I agree with you that it makes sense, but Rodney Dawes the icon naming
> spec and gnome icon theme maintainer thinks it doesn't make sense. See
> http://bugzilla.gnome.org/show_bug.cgi?id=505116
> I've tried to convince him several times of including some icons, but
> he's very keen on keeping the icon set as minimal as possible. You can
> try if you want.

I don't even bother. Eventually they change their mind back and I am not
getting in their way. I couldn't care less.

> > I would like to do it all in one run. Since we depend now on the
> > notifications, we can actually better use the blinking capability and
> > create better visibility for the end user.
> >
> > Ask Andreas how long it would take. I am not an graphics guy at all. So
> > I would have no clue.
> >
>
> You could do me a favor by applying the patch. Now and then I have to
> feel that the time I put in patches is appreciated.
>
> Patches have the tendency not to apply cleanly anymore after a while
> and thus lead to more work.
>
> Even with your suggested enhancements (having enabled/disabled icons)
> this patch still applies. If you manage to convince Rodney to get the
> icons in gnome-icon-theme I'll send you the necessary patch.

I did my own patch to handle the update-icon-cache thing properly in
cases of distcheck and the maintainers.

For now I also only included the 22x22 icons. Still have to re-think the
file structure. Would be nice if we had some nice templates for doing
this properly within one directory.