Re: Undefined symbols in netlink plugin

[alok barsode <alokbarsode@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2621 bytes --]

Hi Ozan,

On Mon, Oct 12, 2009 at 12:18 PM, Ozan Çağlayan <ozan@pardus.org.tr> wrote:
> Ozan Çağlayan wrote On 23-09-2009 01:22:
>
>> Hi,
>>
>> I'm getting the following when I launch bluetoothd with -n -d:
>>
>> ..
>> Can't load plugin /usr/lib/bluetooth/plugins/netlink.so:
>> /usr/lib/bluetooth/plugins/netlink.so: undefined symbol: debug
>> ..
>>
>> AFAIK, those libtool plugins are allowed to have undefined symbols after
>> linking as they will probably be resolved during runtime loading but the
>> warning above wasn't present on previous versions like 4.41 for example.
>>
>> # ldd -u -r /usr/lib/bluetooth/plugins/netlink.so
>>      26771:     /usr/lib/bluetooth/plugins/netlink.so: error: symbol
>> lookup error: undefined symbol: g_io_channel_unix_new (continued)
>> undefined symbol: g_io_channel_unix_new
>> (/usr/lib/bluetooth/plugins/netlink.so)
>>      26771:     /usr/lib/bluetooth/plugins/netlink.so: error: symbol
>> lookup error: undefined symbol: debug (continued)
>> undefined symbol: debug (/usr/lib/bluetooth/plugins/netlink.so)
>>      26771:     /usr/lib/bluetooth/plugins/netlink.so: error: symbol
>> lookup error: undefined symbol: g_io_add_watch (continued)
>> undefined symbol: g_io_add_watch
>> (/usr/lib/bluetooth/plugins/netlink.so)
>>      26771:     /usr/lib/bluetooth/plugins/netlink.so: error: symbol
>> lookup error: undefined symbol: info (continued)
>> undefined symbol: info  (/usr/lib/bluetooth/plugins/netlink.so)
>>      26771:     /usr/lib/bluetooth/plugins/netlink.so: error: symbol
>> lookup error: undefined symbol: g_io_channel_unref (continued)
>> undefined symbol: g_io_channel_unref
>> (/usr/lib/bluetooth/plugins/netlink.so)
>> Unused direct dependencies:
>>
>>
>> So we have 3 undefined symbol from glib and 2 internal symbols from
>> logging.c: debug() and info(). There's no difference if I install the
>> libtool la file or not. Since glib is already needed by bluez daemon,
>> those undefined symbols seems harmless but AFAIK the internal ones
>> should have been linked against the static logging.o.
>>
>> Or do I miss something?
>>

The following patch fixes this issue but I am not sure if its the right way.
Let Marcel take a call on this.

>>
>> Thanks,
>> Ozan Caglayan
>>
>>
>
> Still an issue on bluez 4.56. CC'ing Marcel Holtmann.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Cheers,
Alok.

[-- Attachment #2: 0001-Fix-undefined-symbol-errors-in-netlink-plugin.patch --]
[-- Type: text/x-diff, Size: 845 bytes --]

From f8716244d13e56a8d9116f654001b942f92e20ca Mon Sep 17 00:00:00 2001
From: Alok Barsode <alok.barsode@azingo.com>
Date: Mon, 12 Oct 2009 14:05:20 +0530
Subject: [PATCH 1/1] Fix undefined symbol errors in netlink plugin.

---
 Makefile.am |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index d360acb..fa2497b 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -90,7 +90,8 @@ endif
 if NETLINK
 plugin_LTLIBRARIES += plugins/netlink.la
 
-plugins_netlink_la_LIBADD = @NETLINK_LIBS@
+plugins_netlink_la_SOURCES = plugins/netlink.c src/logging.h src/logging.c
+plugins_netlink_la_LIBADD = @GLIB_LIBS@ @NETLINK_LIBS@
 plugins_netlink_la_LDFLAGS = -module -avoid-version -no-undefined
 plugins_netlink_la_CFLAGS = -fvisibility=hidden @DBUS_CFLAGS@ \
 					@GLIB_CFLAGS@ @NETLINK_CFLAGS@
-- 
1.5.6.3