[Bluez-devel] patch removing one extra memset

Pavel Semerad
2008-01-07T23:09:10Z

Helo,

I have found one mistake in audio/ctl_bluetooth.c . When initializing
this plugin, 'data' is allocated and memset-ed to 0. Then socket is
created and assigned to 'data'. And then there is another memset, which
sets this socket back to zero.
Patch removing this extra memset is attached:

--- ./audio/ctl_bluetooth.c.ps 2007-12-08 20:04:39.000000000 +0100
+++ ./audio/ctl_bluetooth.c 2008-01-07 23:41:23.000000000 +0100
@ -327,8 +327,6 @@ SND_CTL_PLUGIN_DEFINE_FUNC(bluetooth)
if (err < 0)
goto error;

- memset(data, 0, sizeof(*data));
-
data->ext.version = SND_CTL_EXT_VERSION;
data->ext.card_idx = -1;

Pavel Semerad