Re: [PATCH v1] device: Initialize device volume with a valid value

[Jinwang Li <jinwang.li@oss.qualcomm.com>]

On 1/22/2026 2:36 PM, Jinwang Li wrote:
> When AVRCP is connected earlier than AVDTP, this invalid device volume
> causes the A2DP sink to reject the peer's registration for the
> EVENT_VOLUME_CHANGED notification. As a result, subsequent attempts to
> set the volume fail.
> 
> Fixes: fa7828bddd21 ("transport: Fix not being able to initialize volume properly")
> Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
> ---
>   src/device.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/device.c b/src/device.c
> index af8df5f29..cd0b8802e 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -4948,7 +4948,7 @@ static struct btd_device *device_new(struct btd_adapter *adapter,
>   		return NULL;
>   
>   	device->tx_power = 127;
> -	device->volume = -1;
> +	device->volume = 127;
>   	device->wake_id = -1U;
>   
>   	device->db = gatt_db_new();

Hi maintainers,

Do you have any comments on this change?

--
with best wishes
Jinwang