From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Yepuri Siddu <yepuri.siddu@oss.qualcomm.com>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
Rocky Liao <quic_rjliao@quicinc.com>,
quic_mohamull@quicinc.com, quic_hbandi@quicinc.com,
rahul.samana@oss.qualcomm.com, harshitha.reddy@oss.qualcomm.com,
dishank.garg@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: bluetooth: qcom,qcc2072-bt: add bindings for QCC2072
Date: Mon, 1 Jun 2026 10:19:24 +0200 [thread overview]
Message-ID: <9448dfe8-4d9d-4344-be2b-ace371c37975@kernel.org> (raw)
In-Reply-To: <mcn4ysrxrfqo36tr7khsxnjase3priskimkgxuacgma7jcpa46@bgla2znqhyfl>
On 01/06/2026 09:52, Dmitry Baryshkov wrote:
> On Mon, Jun 01, 2026 at 12:50:00PM +0530, Yepuri Siddu wrote:
>>
>>
>> On 5/30/2026 6:04 PM, Krzysztof Kozlowski wrote:
>>> On Fri, May 29, 2026 at 11:23:42PM +0530, Yepuri Siddu wrote:
>>>> Document the YAML binding schema for the Qualcomm QCC2072 UART-based
>>>> Bluetooth controller.
>>>
>>> Where is the rest?
>>>
I repeat the question.
>>>> +properties:
>>>> + compatible:
>>>> + enum:
>>>> + - qcom,qcc2072-bt
>>>> +
>>>> +required:
>>>> + - compatible
>>>> +
>>>
>>> Looks heavily incomplete. Devices do not work without power for example.
>>
>> The module receives power through the M.2 edge connector and manages its
>> own power sequencing internally. Unlike bare Qualcomm Bluetooth SoCs, it
>> requires no external voltage regulators, enable GPIOs, or clock supply
>> from the host, so no power-related properties are needed in the binding.
>
> If this is a purely M.2 device, then it should not be a part of DT.
>
Exactly. And even PCI devices need power sequencing, unless this is a
simple (BT only) device.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-01 8:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 17:53 [PATCH 1/4] dt-bindings: bluetooth: qcom,qcc2072-bt: add bindings for QCC2072 Yepuri Siddu
2026-05-29 20:29 ` [1/4] " bluez.test.bot
2026-05-30 12:34 ` [PATCH 1/4] " Krzysztof Kozlowski
2026-06-01 7:20 ` Yepuri Siddu
2026-06-01 7:52 ` Dmitry Baryshkov
2026-06-01 8:19 ` Krzysztof Kozlowski [this message]
2026-07-02 10:09 ` Yepuri Siddu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9448dfe8-4d9d-4344-be2b-ace371c37975@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dishank.garg@oss.qualcomm.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=harshitha.reddy@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=quic_bgodavar@quicinc.com \
--cc=quic_hbandi@quicinc.com \
--cc=quic_mohamull@quicinc.com \
--cc=quic_rjliao@quicinc.com \
--cc=rahul.samana@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=yepuri.siddu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox