From: Szymon Janc <szymon.janc@tieto.com>
To: Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] android/gatt: Fix passing wrong event len in le dev found
Date: Wed, 02 Apr 2014 14:51:48 +0200 [thread overview]
Message-ID: <9770534.ct3SkaySfx@uw000953> (raw)
In-Reply-To: <1396438617-19549-1-git-send-email-grzegorz.kolodziejczyk@tieto.com>
Hi Grzegorz,
On Wednesday 02 of April 2014 13:36:57 Grzegorz Kolodziejczyk wrote:
> This fix wrong notification length passing to ipc.
> ---
> android/gatt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index 8bd7028..5069f98 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -604,7 +604,7 @@ static void le_device_found_handler(const bdaddr_t *addr, uint8_t addr_type,
>
> ipc_send_notif(hal_ipc, HAL_SERVICE_ID_GATT,
> HAL_EV_GATT_CLIENT_SCAN_RESULT,
> - sizeof(ev) + ev->len, ev);
> + sizeof(*ev) + ev->len, ev);
>
> connect:
> if (!is_device_wating_for_connect(addr, addr_type))
>
Patch applied, thanks.
I've also fixed missing length checks on HAL side.
--
Best regards,
Szymon Janc
prev parent reply other threads:[~2014-04-02 12:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 11:36 [PATCH] android/gatt: Fix passing wrong event len in le dev found Grzegorz Kolodziejczyk
2014-04-02 12:51 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9770534.ct3SkaySfx@uw000953 \
--to=szymon.janc@tieto.com \
--cc=grzegorz.kolodziejczyk@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox