Linux bluetooth development
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [BlueZ, v2] unit: Add test for sdp_xml_parse_record()
Date: Thu, 06 Aug 2026 11:13:25 +0200	[thread overview]
Message-ID: <9b1784ef02eb8e74b68fb382d3958152caf1b045.camel@hadess.net> (raw)
In-Reply-To: <CABBYNZKpGvzN4BUxEFKH6WDpC5tq7iih3uBWrxR9aLRn_RBxpQ@mail.gmail.com>

On Wed, 2026-08-05 at 12:37 -0400, Luiz Augusto von Dentz wrote:
> Hi Bastien,
> 
> On Wed, Aug 5, 2026 at 11:07 AM Bastien Nocera <hadess@hadess.net>
> wrote:
> > 
> > This adds 2 example XML files from other repositories, under a fair
> > use
> > license exception.
> > ---
> > Changes since v1:
> > - Added an "expected result" field, so expected failures can also
> > pass
> >   tests.
> > 
> >  Makefile.am                               |  10 ++
> >  unit/sdp-xml/Bluetooth_HID-sdp_record.xml | 123
> > ++++++++++++++++++++++
> >  unit/sdp-xml/qt-SerialPortSDPRecord.xml   |  57 ++++++++++
> >  unit/test-sdp-xml.c                       |  81 ++++++++++++++
> >  4 files changed, 271 insertions(+)
> >  create mode 100644 unit/sdp-xml/Bluetooth_HID-sdp_record.xml
> >  create mode 100644 unit/sdp-xml/qt-SerialPortSDPRecord.xml
> >  create mode 100644 unit/test-sdp-xml.c
> 
> Why no reuse test-sdp?

Because I did not want to add XML parsing tests to something that
didn't link against it, and separate test binaries can run in parallel
(at least they can in meson), making running loads of small tests
faster than running larger tests.

Note that this patch is just the scaffolding for many other tests I
have locally, so let me know quickly if folding this code into
unit/sdp-xml.c is a requirement to getting it merged.

Cheers

      reply	other threads:[~2026-08-06  9:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-05 15:02 [BlueZ, v2] unit: Add test for sdp_xml_parse_record() Bastien Nocera
2026-08-05 16:13 ` [BlueZ,v2] " bluez.test.bot
2026-08-05 16:37 ` [BlueZ, v2] " Luiz Augusto von Dentz
2026-08-06  9:13   ` Bastien Nocera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b1784ef02eb8e74b68fb382d3958152caf1b045.camel@hadess.net \
    --to=hadess@hadess.net \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox