* [PATCH] eSCO fallback to SCO on Error: Connection Failed to Complete
@ 2010-02-11 20:56 smcoe1
2010-02-11 21:20 ` Nick Pelly
0 siblings, 1 reply; 6+ messages in thread
From: smcoe1 @ 2010-02-11 20:56 UTC (permalink / raw)
To: linux-bluetooth
Below is a patch necessary to pass test case TC_AG_ACS_BC_10_I on
SIG's PTS Software
2007-09-20 12:08:09.471838 > HCI Event: Command Status (0x0f) plen 4
Setup Synchronous Connection (0x01|0x0028) status 0x00 ncmd 1
2007-09-20 12:08:09.479874 > HCI Event: Max Slots Change (0x1b) plen 3
handle 39 slots 1
2007-09-20 12:08:11.821730 > HCI Event: Synchronous Connect Complete
(0x2c) plen 17
status 0x11 handle 39 bdaddr 00:16:93:01:01:7A type eSCO
Error: Unsupported Feature or Parameter Value
2007-09-20 12:08:11.821839 < HCI Command: Setup Synchronous Connection
(0x01|0x0028) plen 17
handle 39 voice setting 0x0060
2007-09-20 12:08:11.824099 > HCI Event: Command Status (0x0f) plen 4
Setup Synchronous Connection (0x01|0x0028) status 0x00 ncmd 0
2007-09-20 12:08:11.832809 > HCI Event: Max Slots Change (0x1b) plen 3
handle 39 slots 5
2007-09-20 12:08:11.832840 > HCI Event: Command Status (0x0f) plen 4
Unknown (0x00|0x0000) status 0x00 ncmd 1
2007-09-20 12:08:11.841195 > HCI Event: Max Slots Change (0x1b) plen 3
handle 39 slots 1
2007-09-20 12:08:12.063088 > HCI Event: Synchronous Connect Complete
(0x2c) plen 17
status 0x00 handle 38 bdaddr 00:16:93:01:01:7A type SCO
Air mode: CVSD
Signed-off-by: Stephen Coe <smcoe1@gmail.com>
---
net/bluetooth/hci_event.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 592da5c..715162c 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1698,6 +1698,7 @@ static inline void
hci_sync_conn_complete_evt(struct hci_dev *hdev, struct sk_bu
hci_conn_add_sysfs(conn);
break;
+ case 0x11: /* Connection Failed to Complete */
case 0x1c: /* SCO interval rejected */
case 0x1a: /* Unsupported Remote Feature */
case 0x1f: /* Unspecified error */
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] eSCO fallback to SCO on Error: Connection Failed to Complete
2010-02-11 20:56 [PATCH] eSCO fallback to SCO on Error: Connection Failed to Complete smcoe1
@ 2010-02-11 21:20 ` Nick Pelly
2010-02-12 16:06 ` smcoe1
0 siblings, 1 reply; 6+ messages in thread
From: Nick Pelly @ 2010-02-11 21:20 UTC (permalink / raw)
To: smcoe1; +Cc: linux-bluetooth
On Thu, Feb 11, 2010 at 12:56 PM, smcoe1 <smcoe1@gmail.com> wrote:
> Below is a patch necessary to pass test case TC_AG_ACS_BC_10_I on
> SIG's PTS Software
>
>
> 2007-09-20 12:08:09.471838 > HCI Event: Command Status (0x0f) plen 4
> Setup Synchronous Connection (0x01|0x0028) status 0x00 ncmd 1
> 2007-09-20 12:08:09.479874 > HCI Event: Max Slots Change (0x1b) plen 3
> handle 39 slots 1
> 2007-09-20 12:08:11.821730 > HCI Event: Synchronous Connect Complete
> (0x2c) plen 17
> status 0x11 handle 39 bdaddr 00:16:93:01:01:7A type eSCO
> Error: Unsupported Feature or Parameter Value
> 2007-09-20 12:08:11.821839 < HCI Command: Setup Synchronous Connection
> (0x01|0x0028) plen 17
> handle 39 voice setting 0x0060
> 2007-09-20 12:08:11.824099 > HCI Event: Command Status (0x0f) plen 4
> Setup Synchronous Connection (0x01|0x0028) status 0x00 ncmd 0
> 2007-09-20 12:08:11.832809 > HCI Event: Max Slots Change (0x1b) plen 3
> handle 39 slots 5
> 2007-09-20 12:08:11.832840 > HCI Event: Command Status (0x0f) plen 4
> Unknown (0x00|0x0000) status 0x00 ncmd 1
> 2007-09-20 12:08:11.841195 > HCI Event: Max Slots Change (0x1b) plen 3
> handle 39 slots 1
> 2007-09-20 12:08:12.063088 > HCI Event: Synchronous Connect Complete
> (0x2c) plen 17
> status 0x00 handle 38 bdaddr 00:16:93:01:01:7A type SCO
> Air mode: CVSD
>
>
> Signed-off-by: Stephen Coe <smcoe1@gmail.com>
> ---
> net/bluetooth/hci_event.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 592da5c..715162c 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -1698,6 +1698,7 @@ static inline void
> hci_sync_conn_complete_evt(struct hci_dev *hdev, struct sk_bu
> hci_conn_add_sysfs(conn);
> break;
>
> + case 0x11: /* Connection Failed to Complete */
You should probably use the real error description which is
"Unsupported Feature Or Parameter Value".
> case 0x1c: /* SCO interval rejected */
> case 0x1a: /* Unsupported Remote Feature */
> case 0x1f: /* Unspecified error */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] eSCO fallback to SCO on Error: Connection Failed to Complete
2010-02-11 21:20 ` Nick Pelly
@ 2010-02-12 16:06 ` smcoe1
2010-02-12 17:56 ` Marcel Holtmann
0 siblings, 1 reply; 6+ messages in thread
From: smcoe1 @ 2010-02-12 16:06 UTC (permalink / raw)
To: Nick Pelly; +Cc: linux-bluetooth
Nick,
Thanks, I guess I wasn't really paying attention, it was a late nite.
Signed-off-by: Stephen Coe <smcoe1@gmail.com>
---
net/bluetooth/hci_event.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 592da5c..6c57fc7 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1698,6 +1698,7 @@ static inline void
hci_sync_conn_complete_evt(struct hci_dev *hdev, struct sk_bu
hci_conn_add_sysfs(conn);
break;
+ case 0x11: /* Unsupported Feature or Parameter Value */
case 0x1c: /* SCO interval rejected */
case 0x1a: /* Unsupported Remote Feature */
case 0x1f: /* Unspecified error */
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] eSCO fallback to SCO on Error: Connection Failed to Complete
2010-02-12 16:06 ` smcoe1
@ 2010-02-12 17:56 ` Marcel Holtmann
2010-02-16 15:21 ` smcoe1
0 siblings, 1 reply; 6+ messages in thread
From: Marcel Holtmann @ 2010-02-12 17:56 UTC (permalink / raw)
To: smcoe1; +Cc: Nick Pelly, linux-bluetooth
Hi Stephen,
> Thanks, I guess I wasn't really paying attention, it was a late nite.
>
> Signed-off-by: Stephen Coe <smcoe1@gmail.com>
> ---
> net/bluetooth/hci_event.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 592da5c..6c57fc7 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -1698,6 +1698,7 @@ static inline void
> hci_sync_conn_complete_evt(struct hci_dev *hdev, struct sk_bu
> hci_conn_add_sysfs(conn);
> break;
>
> + case 0x11: /* Unsupported Feature or Parameter Value */
> case 0x1c: /* SCO interval rejected */
> case 0x1a: /* Unsupported Remote Feature */
> case 0x1f: /* Unspecified error */
I need a proper patch with the hcidump and the name of the device that
causes this issue. See how Nick has done it lately.
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] eSCO fallback to SCO on Error: Connection Failed to Complete
2010-02-12 17:56 ` Marcel Holtmann
@ 2010-02-16 15:21 ` smcoe1
2010-02-16 15:40 ` Marcel Holtmann
0 siblings, 1 reply; 6+ messages in thread
From: smcoe1 @ 2010-02-16 15:21 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: Nick Pelly, linux-bluetooth
The Bluetooth SIG PTS test case: TC_AG_ACS_BV_10_I, rejects eSCO with
"Unsupported Feature or Parameter Value" (0x11). This patch adds case
for SCO fall back.
2007-09-20 12:20:37.787747 > HCI Event: Number of Completed Packets
(0x13) plen 5
handle 38 packets 1
2007-09-20 12:20:37.842154 < HCI Command: Setup Synchronous Connection
(0x01|0x0028) plen 17
handle 38 voice setting 0x0060
2007-09-20 12:20:37.847037 > HCI Event: Command Status (0x0f) plen 4
Setup Synchronous Connection (0x01|0x0028) status 0x00 ncmd 1
2007-09-20 12:20:37.855233 > HCI Event: Max Slots Change (0x1b) plen 3
handle 38 slots 1
2007-09-20 12:20:39.913354 > HCI Event: Synchronous Connect Complete
(0x2c) plen 17
status 0x11 handle 38 bdaddr 00:16:93:01:01:7A type eSCO
Error: Unsupported Feature or Parameter Value
2007-09-20 12:20:39.922629 > HCI Event: Max Slots Change (0x1b) plen 3
handle 38 slots 5
2007-09-20 12:20:58.126886 < ACL data: handle 38 flags 0x02 dlen 8
L2CAP(d): cid 0x0041 len 4 [psm 0]
0000: 0b 53 01 b8 .S..
2007-09-20 12:20:58.130138 > HCI Event: Number of Completed Packets
(0x13) plen 5
handle 38 packets 1
Signed-off-by: Stephen Coe <smcoe1@gmail.com>
---
net/bluetooth/hci_event.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 592da5c..6c57fc7 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1698,6 +1698,7 @@ static inline void
hci_sync_conn_complete_evt(struct hci_dev *hdev, struct sk_bu
hci_conn_add_sysfs(conn);
break;
+ case 0x11: /* Unsupported Feature or Parameter Value */
case 0x1c: /* SCO interval rejected */
case 0x1a: /* Unsupported Remote Feature */
case 0x1f: /* Unspecified error */
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] eSCO fallback to SCO on Error: Connection Failed to Complete
2010-02-16 15:21 ` smcoe1
@ 2010-02-16 15:40 ` Marcel Holtmann
0 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2010-02-16 15:40 UTC (permalink / raw)
To: smcoe1; +Cc: Nick Pelly, linux-bluetooth
Hi Stephen,
> The Bluetooth SIG PTS test case: TC_AG_ACS_BV_10_I, rejects eSCO with
> "Unsupported Feature or Parameter Value" (0x11). This patch adds case
> for SCO fall back.
>
> 2007-09-20 12:20:37.787747 > HCI Event: Number of Completed Packets
> (0x13) plen 5
> handle 38 packets 1
> 2007-09-20 12:20:37.842154 < HCI Command: Setup Synchronous Connection
> (0x01|0x0028) plen 17
> handle 38 voice setting 0x0060
> 2007-09-20 12:20:37.847037 > HCI Event: Command Status (0x0f) plen 4
> Setup Synchronous Connection (0x01|0x0028) status 0x00 ncmd 1
> 2007-09-20 12:20:37.855233 > HCI Event: Max Slots Change (0x1b) plen 3
> handle 38 slots 1
> 2007-09-20 12:20:39.913354 > HCI Event: Synchronous Connect Complete
> (0x2c) plen 17
> status 0x11 handle 38 bdaddr 00:16:93:01:01:7A type eSCO
> Error: Unsupported Feature or Parameter Value
> 2007-09-20 12:20:39.922629 > HCI Event: Max Slots Change (0x1b) plen 3
> handle 38 slots 5
> 2007-09-20 12:20:58.126886 < ACL data: handle 38 flags 0x02 dlen 8
> L2CAP(d): cid 0x0041 len 4 [psm 0]
> 0000: 0b 53 01 b8 .S..
> 2007-09-20 12:20:58.130138 > HCI Event: Number of Completed Packets
> (0x13) plen 5
> handle 38 packets 1
>
>
>
> Signed-off-by: Stephen Coe <smcoe1@gmail.com>
>
> ---
> net/bluetooth/hci_event.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 592da5c..6c57fc7 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -1698,6 +1698,7 @@ static inline void
> hci_sync_conn_complete_evt(struct hci_dev *hdev, struct sk_bu
> hci_conn_add_sysfs(conn);
> break;
>
your mailer seem to have corrupted the patch. Make sure it doesn't
introduce any line break. Or better just use git send-email.
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-02-16 15:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-11 20:56 [PATCH] eSCO fallback to SCO on Error: Connection Failed to Complete smcoe1
2010-02-11 21:20 ` Nick Pelly
2010-02-12 16:06 ` smcoe1
2010-02-12 17:56 ` Marcel Holtmann
2010-02-16 15:21 ` smcoe1
2010-02-16 15:40 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).