linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: smcoe1 <smcoe1@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Nick Pelly <npelly@google.com>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] eSCO fallback to SCO on Error: Connection Failed to Complete
Date: Tue, 16 Feb 2010 10:21:51 -0500	[thread overview]
Message-ID: <9c9ad6a31002160721j38fc388u99e35234f28270ed@mail.gmail.com> (raw)
In-Reply-To: <1265997402.21559.0.camel@localhost.localdomain>

The Bluetooth SIG PTS test case: TC_AG_ACS_BV_10_I, rejects eSCO with
"Unsupported Feature or Parameter Value" (0x11).  This patch adds case
for SCO fall back.

2007-09-20 12:20:37.787747 > HCI Event: Number of Completed Packets
(0x13) plen 5
    handle 38 packets 1
2007-09-20 12:20:37.842154 < HCI Command: Setup Synchronous Connection
(0x01|0x0028) plen 17
    handle 38 voice setting 0x0060
2007-09-20 12:20:37.847037 > HCI Event: Command Status (0x0f) plen 4
    Setup Synchronous Connection (0x01|0x0028) status 0x00 ncmd 1
2007-09-20 12:20:37.855233 > HCI Event: Max Slots Change (0x1b) plen 3
    handle 38 slots 1
2007-09-20 12:20:39.913354 > HCI Event: Synchronous Connect Complete
(0x2c) plen 17
    status 0x11 handle 38 bdaddr 00:16:93:01:01:7A type eSCO
    Error: Unsupported Feature or Parameter Value
2007-09-20 12:20:39.922629 > HCI Event: Max Slots Change (0x1b) plen 3
    handle 38 slots 5
2007-09-20 12:20:58.126886 < ACL data: handle 38 flags 0x02 dlen 8
    L2CAP(d): cid 0x0041 len 4 [psm 0]
      0000: 0b 53 01 b8                                       .S..
2007-09-20 12:20:58.130138 > HCI Event: Number of Completed Packets
(0x13) plen 5
    handle 38 packets 1



Signed-off-by: Stephen Coe <smcoe1@gmail.com>
---
 net/bluetooth/hci_event.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 592da5c..6c57fc7 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1698,6 +1698,7 @@ static inline void
hci_sync_conn_complete_evt(struct hci_dev *hdev, struct sk_bu
        hci_conn_add_sysfs(conn);
        break;

+   case 0x11:  /* Unsupported Feature or Parameter Value */
    case 0x1c:  /* SCO interval rejected */
    case 0x1a:  /* Unsupported Remote Feature */
    case 0x1f:  /* Unspecified error */

  reply	other threads:[~2010-02-16 15:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-11 20:56 [PATCH] eSCO fallback to SCO on Error: Connection Failed to Complete smcoe1
2010-02-11 21:20 ` Nick Pelly
2010-02-12 16:06   ` smcoe1
2010-02-12 17:56     ` Marcel Holtmann
2010-02-16 15:21       ` smcoe1 [this message]
2010-02-16 15:40         ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c9ad6a31002160721j38fc388u99e35234f28270ed@mail.gmail.com \
    --to=smcoe1@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=npelly@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).