Re: [PATCH BlueZ 1/2] unit: Add unit test for new MIN/MAX macros

[Bastien Nocera <hadess@hadess.net>]

Hey Luiz,

I believe those 2 patches are also ready for review.

Cheers

On Wed, 2026-04-01 at 22:45 +0200, Bastien Nocera wrote:
> ---
>  Makefile.am      |  4 ++++
>  unit/test-util.c | 34 ++++++++++++++++++++++++++++++++++
>  2 files changed, 38 insertions(+)
>  create mode 100644 unit/test-util.c
> 
> diff --git a/Makefile.am b/Makefile.am
> index 2cfb884f1851..d9de71d587d8 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -696,6 +696,10 @@ unit_test_lib_SOURCES = unit/test-lib.c
>  unit_test_lib_LDADD = src/libshared-glib.la \
>  				lib/libbluetooth-internal.la
> $(GLIB_LIBS)
>  
> +unit_tests += unit/test-util
> +unit_test_util_LDADD = src/libshared-glib.la \
> +				lib/libbluetooth-internal.la
> $(GLIB_LIBS)
> +
>  unit_tests += unit/test-gatt
>  
>  unit_test_gatt_SOURCES = unit/test-gatt.c
> diff --git a/unit/test-util.c b/unit/test-util.c
> new file mode 100644
> index 000000000000..8ab16cc083ba
> --- /dev/null
> +++ b/unit/test-util.c
> @@ -0,0 +1,34 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + *
> + *  BlueZ - Bluetooth protocol stack for Linux
> + *
> + *  Copyright (C) 2026  Bastien Nocera <hadess@hadess.net>
> + *
> + *
> + */
> +
> +#include <assert.h>
> +
> +#include "src/shared/util.h"
> +#include "src/shared/tester.h"
> +
> +/* XXX glib.h must not be included, or it will clobber the
> + * MIN/MAX macros */
> +
> +static void test_min_max(const void *data)
> +{
> +	assert(MIN(3, 4) == 3);
> +	assert(MAX(3, 4) == 4);
> +	tester_test_passed();
> +}
> +
> +int main(int argc, char *argv[])
> +{
> +	tester_init(&argc, &argv);
> +
> +	tester_add("/util/min_max", NULL, NULL,
> +			test_min_max, NULL);
> +
> +	return tester_run();
> +}