From: "João Paulo Rechi Vita" <jprvita@gmail.com>
To: "Gustavo F. Padovan" <padovan@profusion.mobi>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
gustavo@padovan.org
Subject: Re: [l2cap 6/6] Bluetooth: Only check SAR bits if frame is I-frame
Date: Wed, 12 May 2010 15:36:48 -0300 [thread overview]
Message-ID: <AANLkTilYb-ZtPFbEI9xVd0yUjiXsD6az7nhvhef5Gfyk@mail.gmail.com> (raw)
In-Reply-To: <1273633558-10576-6-git-send-email-padovan@profusion.mobi>
On Wed, May 12, 2010 at 00:05, Gustavo F. Padovan
<padovan@profusion.mobi> wrote:
> Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
> ---
> =C2=A0net/bluetooth/l2cap.c | =C2=A0 =C2=A02 +-
> =C2=A01 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
> index dbd43d1..2192b9c 100644
> --- a/net/bluetooth/l2cap.c
> +++ b/net/bluetooth/l2cap.c
> @@ -4123,7 +4123,7 @@ static inline int l2cap_data_channel(struct l2cap_c=
onn *conn, u16 cid, struct sk
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (l2cap_check_fc=
s(pi, skb))
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0goto drop;
>
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (__is_sar_start(con=
trol))
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (__is_sar_start(con=
trol) && __is_iframe(control))
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0len -=3D 2;
>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (pi->fcs =3D=3D=
L2CAP_FCS_CRC16)
> --
> 1.6.4.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth=
" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at =C2=A0http://vger.kernel.org/majordomo-info.html
>
The whole series looks good to me.
--=20
Jo=C3=A3o Paulo Rechi Vita
http://jprvita.wordpress.com/
next prev parent reply other threads:[~2010-05-12 18:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 17:39 [PATCH 1/2] Bluetooth: Remove max_tx and tx_window modules paramenter from L2CAP Gustavo F. Padovan
2010-05-10 17:39 ` [PATCH 2/2] Bluetooth: Remove L2CAP Extended Features from Kconfig Gustavo F. Padovan
2010-05-12 3:05 ` [l2cap 1/6] Bluetooth: Tweaks to l2cap_send_i_or_rr_or_rnr() flow Gustavo F. Padovan
2010-05-12 3:05 ` [l2cap 2/6] Bluetooth: Fix drop of packets with invalid req_seq/tx_seq Gustavo F. Padovan
2010-05-12 3:05 ` [l2cap 3/6] Bluetooth: Check skb_clone return to avoid NULL dereference Gustavo F. Padovan
2010-05-12 3:05 ` [l2cap 4/6] Bluetooth: Fix ERTM vars increment Gustavo F. Padovan
2010-05-12 3:05 ` [l2cap 5/6] Bluetooth: Check packet FCS earlier Gustavo F. Padovan
2010-05-12 3:05 ` [l2cap 6/6] Bluetooth: Only check SAR bits if frame is I-frame Gustavo F. Padovan
2010-05-12 18:36 ` João Paulo Rechi Vita [this message]
2010-05-12 21:59 ` [PATCH] Bluetooth: Stop ack_timer if ERTM enters in Local Busy or SREJ_SENT Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTilYb-ZtPFbEI9xVd0yUjiXsD6az7nhvhef5Gfyk@mail.gmail.com \
--to=jprvita@gmail.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).