From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cyrus@holtmann.org>
MIME-Version: 1.0
In-Reply-To: <20100719184017.GA13327@vigoh>
References: <1279311633-12131-1-git-send-email-gustavo@padovan.org>
	<AANLkTilHzxBXd2KemlUhfJPnqVjDS5eIbkC_JWc-aKwm@mail.gmail.com>
	<20100719184017.GA13327@vigoh>
Date: Mon, 19 Jul 2010 15:03:33 -0400
Message-ID: <AANLkTilbCpi-Dt-Pk1w3o7wahMNiAXIweC4xE1Y-skZ3@mail.gmail.com>
Subject: Re: [PATCH] Bluetooth: Move bit-field var to data->flags
From: Anderson Lizardo <anderson.lizardo@openbossa.org>
To: "Gustavo F. Padovan" <gustavo@padovan.org>
Cc: linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

On Mon, Jul 19, 2010 at 2:40 PM, Gustavo F. Padovan <gustavo@padovan.org> wrote:
>> On Fri, Jul 16, 2010 at 4:20 PM, Gustavo F. Padovan <gustavo@padovan.org> wrote:
>> > @@ -810,7 +810,7 @@ static void btusb_work(struct work_struct *work)
>> >        int err;
>> >
>> >        if (hdev->conn_hash.sco_num > 0) {
>> > -               if (!data->did_iso_resume) {
>> > +               if (!test_bit(BTUSB_DID_ISO_RESUME, &data->flags)) {
>> >                        err = usb_autopm_get_interface(data->isoc);
>> >                        if (err < 0) {
>> >                                clear_bit(BTUSB_ISOC_RUNNING, &data->flags);
>> > @@ -818,7 +818,7 @@ static void btusb_work(struct work_struct *work)
>> >                                return;
>> >                        }
>> >
>> > -                       data->did_iso_resume = 1;
>> > +                       set_bit(BTUSB_DID_ISO_RESUME, &data->flags);
>> >                }
>> >                if (data->isoc_altsetting != 2) {
>> >                        clear_bit(BTUSB_ISOC_RUNNING, &data->flags);
>>
>> Just wondering ... could test_and_set_bit() be used here (instead of
>> test_bit() + set_bit()) ?
>
> No, because usb_autopm_get_interface() can return a error. In that case
> we shall not set the bit.

Ok, but in this case looks like there is a clear_bit() already there.

Regards,
-- 
Anderson Lizardo
OpenBossa Labs - INdT
Manaus - Brazil