public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavan Savoy <pavan_savoy@sify.com>
To: padovan@profusion.mobi, marcel@holtmann.org
Cc: linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	Pavan Savoy <pavan_savoy@ti.com>
Subject: Re: [RFC 0/2] remove BT references from TI_ST
Date: Wed, 19 Jan 2011 23:56:29 +0530	[thread overview]
Message-ID: <AANLkTinPC-i2xi9pCQ-RzGWuwZ5uTM3NXG7y6gwTnPYv@mail.gmail.com> (raw)
In-Reply-To: <1294138788-10307-1-git-send-email-pavan_savoy@ti.com>

Gustavo,

On Tue, Jan 4, 2011 at 4:29 PM,  <pavan_savoy@ti.com> wrote:
> From: Pavan Savoy <pavan_savoy@ti.com>
>
> Gustavo,
>
> Based on your comments, that the underlying shared transport driver
> for btwilink driver made use of the BT references to peek into the packets
> I have modified the TI_ST.

Since there lacks a generic way to parse the packets coming in from the
UART into BT, FM or GPS, we have to look into the data to fragment assembled
data or assemble fragmented data.

Please have a look, Please suggest whether something like this is required,
If not, please also suggest, if including BT headers is a problem ?

Because I just include the BT headers and don't have a build
dependency as such on
BT/HCI and don't use any functions from hci_core in my shared transport driver.

> For this reason, Now the above lying protocol drivers like BT, FM and GPS
> would send details about their packet types and header information which
> would assist shared transport driver to parse the data.
>
> Gustavo, please also notice the change in btwilink driver in and around,
> st_register and suggest if something like this is OK.
> btwilink can also be modified to send in all the packet specific data
> in one shot, if that is preferred.
>
> Please review and provide comments..
>
> Note:
> If this is alright, I will send out a modified patch with updated
> subject to lkml/Greg for linux-next.
>
> Thanks & Regards,
> Pavan Savoy.
>
> Pavan Savoy (2):
>  drivers:misc:ti-st: change protocol parse logic
>  Bluetooth: btwilink driver
>
>  drivers/bluetooth/Kconfig    |   10 +
>  drivers/bluetooth/Makefile   |    1 +
>  drivers/bluetooth/btwilink.c |  397 ++++++++++++++++++++++++++++++++++++++++++
>  drivers/misc/ti-st/st_core.c |  355 ++++++++++++--------------------------
>  drivers/misc/ti-st/st_kim.c  |   56 +++---
>  include/linux/ti_wilink_st.h |   40 +++--
>  6 files changed, 575 insertions(+), 284 deletions(-)
>  create mode 100644 drivers/bluetooth/btwilink.c
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

  parent reply	other threads:[~2011-01-19 18:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04 10:59 [RFC 0/2] remove BT references from TI_ST pavan_savoy
2011-01-04 10:59 ` [RFC 1/2] drivers:misc:ti-st: change protocol parse logic pavan_savoy
2011-01-04 10:59   ` [RFC 2/2] Bluetooth: btwilink driver pavan_savoy
2011-01-21 17:57     ` Gustavo F. Padovan
2011-01-19 18:26 ` Pavan Savoy [this message]
2011-01-21 17:18   ` [RFC 0/2] remove BT references from TI_ST Gustavo F. Padovan
2011-01-21 17:40     ` Pavan Savoy
2011-01-21 18:27       ` Gustavo F. Padovan
2011-01-21 21:10         ` Pavan Savoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinPC-i2xi9pCQ-RzGWuwZ5uTM3NXG7y6gwTnPYv@mail.gmail.com \
    --to=pavan_savoy@sify.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=padovan@profusion.mobi \
    --cc=pavan_savoy@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox