Linux bluetooth development
 help / color / mirror / Atom feed
From: "David Stockwell" <dstockwell@frequency-one.com>
To: "João Paulo Rechi Vita" <jprvita@gmail.com>,
	linux-bluetooth@vger.kernel.org
Cc: "Sander van Grieken" <sander@outrightsolutions.nl>,
	"Shivendra Agrawal" <ag.shivendra@gmail.com>,
	"Waldemar Rymarkiewicz" <Waldemar.Rymarkiewicz@tieto.com>,
	"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
	"Johan Hedberg" <johan.hedberg@gmail.com>
Subject: AVRCP 1.3/1.4 current implementation
Date: Sat, 30 Oct 2010 12:57:31 -0500	[thread overview]
Message-ID: <AF6253527A02449484D3BA2FF254AE2B@freqoneremote> (raw)
In-Reply-To: <AANLkTi=ThA2ojhj8PBHK_VybmFcHO91K0g=y7nhfTBAO@mail.gmail.com>

Hello to all,

In my earlier work, I noticed that in audio/manager.c, function 
handle_uuids, when the UUID was found for an AVRCP target or controller, it 
would only launch avrcp_connect IF a Sink was enabled and present.

I suspect this was done to make sure that if a headset or similar was 
connecting, it would make sure the audio side of the connection was up and 
running before enabling the control side of the interface.

However, my device has no audio side, it is a pure AVRCP CT, so there is no 
audio-side connection.  In previous testing, I just unconditionally started 
avrcp_connect and it all worked fine for my purposes.  I am wondering if 
there is any other impact.

I could submit the patch in which avrcp_connect is unconditionally called. 
Or, I could just wait until all of the uuids are processed (after the 
g_slist_foreach in audio_probe), then launch avrcp_connect if either (a) a 
sink is connected and enabled as at present, or (b) if no sink is called for 
or provided by the CT/TG (as expressed in SDP), just launch avrcp_connect 
without the sink.  Are there any other impacts that this might cause?

To Joao, I would like to test my device against the GSOC work you did; can 
you send me the URL?  If you are farther along, no sense re-inventing the 
wheel. Thanks/obrigado.

David Stockwell 


  parent reply	other threads:[~2010-10-30 17:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19  9:47 AVRCP 1.4 : Future on Target Role Sander van Grieken
2010-10-19 16:14 ` Luiz Augusto von Dentz
2010-10-20  4:27   ` Shivendra Agrawal
2010-10-20 22:24     ` David Stockwell
2010-10-21  8:30       ` Waldemar.Rymarkiewicz
2010-10-21 21:27         ` David Stockwell
2010-10-23 15:50   ` João Paulo Rechi Vita
     [not found]     ` <AANLkTimGO9-_odEX-=8Lttw1D3M=X+DWJH0w45W8nMtT@mail.gmail.com>
     [not found]       ` <AANLkTi=g+8UDsSQBnqBWk=Ly=xCmfvwX_ZCMsn_kU9Fb@mail.gmail.com>
2010-10-27  6:57         ` shivendra.agrawal@stericsson.com
2010-10-27  7:33           ` Gustavo F. Padovan
2010-10-27  8:46     ` shivendra.agrawal@stericsson.com
2010-10-30 17:57     ` David Stockwell [this message]
2010-10-30 18:54       ` AVRCP 1.3/1.4 current implementation Sander van Grieken

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AF6253527A02449484D3BA2FF254AE2B@freqoneremote \
    --to=dstockwell@frequency-one.com \
    --cc=Waldemar.Rymarkiewicz@tieto.com \
    --cc=ag.shivendra@gmail.com \
    --cc=johan.hedberg@gmail.com \
    --cc=jprvita@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=sander@outrightsolutions.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox