* [PATCH] Bluetooth: Don't mark URB_ISO_ASAP urbs for non xfer isoc endpoints
@ 2012-01-03 10:47 Daniel Wagner
2012-01-03 12:03 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Wagner @ 2012-01-03 10:47 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Daniel Wagner
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
[ 2096.384084] btusb_send_frame:684: hci0
[ 2096.384087] usb 3-1: BOGUS urb flags, 2 --> 0
[ 2096.384091] Bluetooth: hci0 urb ffff8801b61d3a80 submission failed (22)
According the documentation in usb_submit_urb() URB_ISO_ASAP
flag is only allowed for endpoints of type USB_ENDPOINT_XFER_ISOC.
This reverts commit b8aabfc92249b239c425da7e4ca85b7e4855e984.
---
drivers/bluetooth/btusb.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index fbfba80..77b9f7b 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -726,9 +726,6 @@ static int btusb_send_frame(struct sk_buff *skb)
usb_fill_bulk_urb(urb, data->udev, pipe,
skb->data, skb->len, btusb_tx_complete, skb);
- if (skb->priority >= HCI_PRIO_MAX - 1)
- urb->transfer_flags = URB_ISO_ASAP;
-
hdev->stat.acl_tx++;
break;
--
1.7.8.110.g4cb5d1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: Don't mark URB_ISO_ASAP urbs for non xfer isoc endpoints
2012-01-03 10:47 [PATCH] Bluetooth: Don't mark URB_ISO_ASAP urbs for non xfer isoc endpoints Daniel Wagner
@ 2012-01-03 12:03 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2012-01-03 12:03 UTC (permalink / raw)
To: Daniel Wagner; +Cc: linux-bluetooth, Daniel Wagner
Hi Daniel,
On Tue, Jan 3, 2012 at 12:47 PM, Daniel Wagner <wagi@monom.org> wrote:
> From: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> [ 2096.384084] btusb_send_frame:684: hci0
> [ 2096.384087] usb 3-1: BOGUS urb flags, 2 --> 0
> [ 2096.384091] Bluetooth: hci0 urb ffff8801b61d3a80 submission failed (22)
>
> According the documentation in usb_submit_urb() URB_ISO_ASAP
> flag is only allowed for endpoints of type USB_ENDPOINT_XFER_ISOC.
>
> This reverts commit b8aabfc92249b239c425da7e4ca85b7e4855e984.
> ---
> drivers/bluetooth/btusb.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index fbfba80..77b9f7b 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -726,9 +726,6 @@ static int btusb_send_frame(struct sk_buff *skb)
> usb_fill_bulk_urb(urb, data->udev, pipe,
> skb->data, skb->len, btusb_tx_complete, skb);
>
> - if (skb->priority >= HCI_PRIO_MAX - 1)
> - urb->transfer_flags = URB_ISO_ASAP;
> -
> hdev->stat.acl_tx++;
> break;
>
> --
> 1.7.8.110.g4cb5d1
Kernel patches requires Signed-off-by, fill free to include my ack too.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-03 12:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-03 10:47 [PATCH] Bluetooth: Don't mark URB_ISO_ASAP urbs for non xfer isoc endpoints Daniel Wagner
2012-01-03 12:03 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).