From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Denis Kenzior <denkenz@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
"Stotland, Inga" <inga.stotland@intel.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ] shared/io-ell: Add support for ELL based IO handling
Date: Thu, 17 May 2018 11:01:58 +0300 [thread overview]
Message-ID: <CABBYNZ+dmaLOTOJgYMoLS2jzWNZCqHYjVvcJsKYiFTgv1en-wg@mail.gmail.com> (raw)
In-Reply-To: <5b6349ba-e0dd-8b56-5654-c1e0e20be4a8@gmail.com>
Hi,
On Wed, May 16, 2018 at 5:42 PM Denis Kenzior <denkenz@gmail.com> wrote:
> Hi,
> >> +
> >> + do {
> >> + ret = writev(fd, iov, iovcnt);
> >> + } while (ret < 0 && errno == EINTR);
> >
> > explain this one to me. Or maybe Luiz should explain it since he
introduced this.
> >
> I'm curious why not use TEMP_FAILURE_RETRY macro? ell already uses that
> for clarity.
Szymon was actually suggesting that we should have something similar in
ell, e.g. l_io_send, it would be nice if that would handle iovec similarly
to how is done here but perhaps using the TEMP_FAILURE_RETRY as suggested
by Denis.
--
Luiz Augusto von Dentz
next prev parent reply other threads:[~2018-05-17 8:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 23:56 [PATCH BlueZ] shared/io-ell: Add support for ELL based IO handling Inga Stotland
2018-05-16 12:47 ` Luiz Augusto von Dentz
2018-05-16 13:35 ` Marcel Holtmann
2018-05-16 14:39 ` Denis Kenzior
2018-05-17 8:01 ` Luiz Augusto von Dentz [this message]
2018-05-17 15:01 ` Denis Kenzior
2018-05-17 16:03 ` Luiz Augusto von Dentz
2018-05-17 16:29 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABBYNZ+dmaLOTOJgYMoLS2jzWNZCqHYjVvcJsKYiFTgv1en-wg@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=denkenz@gmail.com \
--cc=inga.stotland@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).