From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] obex: Fix checking incorrect error code
Date: Mon, 9 Dec 2013 11:56:30 +0200 [thread overview]
Message-ID: <CABBYNZJHT3V7NEKPHZiXOKCzOiTPnfvH5w-WuCcL1GyCC-tnNg@mail.gmail.com> (raw)
In-Reply-To: <20131209080310.GC6506@aemeltch-MOBL1>
Hi Andrei,
On Mon, Dec 9, 2013 at 10:03 AM, Andrei Emeltchenko
<Andrei.Emeltchenko.news@gmail.com> wrote:
> ping
>
> On Tue, Dec 03, 2013 at 06:04:54PM +0200, Andrei Emeltchenko wrote:
>> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>>
>> chdir return -1 if error and 0 in success. Checking for > 0 is pointless.
>> ---
>> tools/obex-server-tool.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/obex-server-tool.c b/tools/obex-server-tool.c
>> index e37c56f..86c2271 100644
>> --- a/tools/obex-server-tool.c
>> +++ b/tools/obex-server-tool.c
>> @@ -427,7 +427,7 @@ int main(int argc, char *argv[])
>> exit(EXIT_FAILURE);
>> }
>>
>> - if (option_root && chdir(option_root) > 0) {
>> + if (option_root && chdir(option_root) < 0) {
>> perror("chdir:");
>> exit(EXIT_FAILURE);
>> }
>> --
>> 1.8.3.2
Pushed, thanks.
--
Luiz Augusto von Dentz
prev parent reply other threads:[~2013-12-09 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 16:04 [PATCH] obex: Fix checking incorrect error code Andrei Emeltchenko
2013-12-09 8:03 ` Andrei Emeltchenko
2013-12-09 9:56 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABBYNZJHT3V7NEKPHZiXOKCzOiTPnfvH5w-WuCcL1GyCC-tnNg@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).