Re: [PATCH BlueZ v2] unit: Add Mesh Crypto tests from Mesh Profile Spec

[Luiz Augusto von Dentz <luiz.dentz@gmail.com>]

Hi Brian,

On Wed, Oct 9, 2019 at 7:01 PM Gix, Brian <brian.gix@intel.com> wrote:
>
> Hi Luiz,
>
> On Wed, 2019-10-09 at 17:59 +0300, Luiz Augusto von Dentz wrote:
> > On Thu, 2019-10-03 at 13:44 -0700, Brian Gix wrote:
> > > > This unit test will be grown over time to include tests formed from the
> > > > sample data in the Bluetooth Mesh Profile specification (Currently at
> > > > version v1.0.1).
> > > >
> > > > Currently it includes test cases for the following sets of sample data:
> > > > Sections 8.1.1-6
> > > > Sections 8.2.1-6
> > > > Sections 8.3.1-11
> > > > Section 8.4.3
> > > > Section 8.6.2
> > > > ---
> > > >  Makefile.am             |   10 +
> > > >  unit/test-mesh-crypto.c | 2000 +++++++++++++++++++++++++++++++++++++++
> > > >  2 files changed, 2010 insertions(+)
> > > >  create mode 100644 unit/test-mesh-crypto.c
> > > >
> >
> > make test is failing on this one:
>
> What platform/command line are you getting to see this?  or are you running it under a static analysis tool of
> some sort?
>
> I am getting no errors on F30, bith 32 and 64 bit...
>
> But I will check out the check_id_beacon() function...

I think you might not have valgrind installed or the build is not able
to detect, anyway you can run the test manually like this:

valgrind --trace-children=yes --leak-check=full --show-reachable=no
unit/test-mesh-crypto

> >
> > ==25559== 8 bytes in 1 blocks are definitely lost in loss record 1 of 4
> > ==25559==    at 0x483880B: malloc (vg_replace_malloc.c:309)
> > ==25559==    by 0x11FB25: l_malloc (util.c:62)
> > ==25559==    by 0x120232: l_util_from_hexstring (util.c:427)
> > ==25559==    by 0x118069: check_id_beacon (test-mesh-crypto.c:1709)
> > ==25559==    by 0x118069: main (test-mesh-crypto.c:1997)
> >
> > Btw usually the test are using the tester framework and it should be
> > possible to integrate with that but that probably need some work to
> > make you able to run with ell mainloop.
> >
> >
> >
> >
> > --
> > Luiz Augusto von Dentz



-- 
Luiz Augusto von Dentz