From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: intelfx@intelfx.name
Cc: "linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Subject: Re: Fallout from commit 70fdb77 "audio/avrcp: Fix not always requesting capabilities"
Date: Fri, 1 Apr 2016 12:31:03 +0300 [thread overview]
Message-ID: <CABBYNZJe5FhhUqQTX89Soaig12ybWv90q7849jqVj2hrgxv5qw@mail.gmail.com> (raw)
In-Reply-To: <1459443653.22297.7.camel@intelfx.name>
Hi Ivan,
On Thu, Mar 31, 2016 at 8:00 PM, Ivan Shapovalov <intelfx@intelfx.name> wrote:
> Hello,
>
> The commit 70fdb7 "audio/avrcp: Fix not always requesting capabilities"
> introduced a series of bugs where the code thinks that session-
>>controller->player cannot be NULL, but in fact it can be so. The first
> one was fixed in 177d27 "audio/avrcp: Fix crash when connecting to controllers", but there remain multiple code pathes via avrcp_register_notification() -> callback -> avrcp_handle_event() -> avrcp_{status,track,playback_pos,settings,uids}_changed() where session->controller->player may be dereferenced.
>
> I'm unsure how to fix that properly (either not register notifications,
> or ignore specific callbacks if s->c->player is NULL), so I'm just
> reporting this.
>
> Ref.: https://bugs.archlinux.org/task/48644
Ive just sent a patch to prevent the above to happen, it is very
uncommon that those event would be supported for a controller that
does not have player capabilities but indeed it could cause crashes.
--
Luiz Augusto von Dentz
prev parent reply other threads:[~2016-04-01 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 17:00 Fallout from commit 70fdb77 "audio/avrcp: Fix not always requesting capabilities" Ivan Shapovalov
2016-04-01 9:31 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABBYNZJe5FhhUqQTX89Soaig12ybWv90q7849jqVj2hrgxv5qw@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=intelfx@intelfx.name \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).