linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: John Keeping <john@metanate.com>
Cc: "linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	Andrzej Kaczmarek <andrzej.kaczmarek@codecoup.pl>
Subject: Re: [PATCH] tools/avinfo: fix big endian build
Date: Fri, 26 Feb 2016 14:03:51 +0200	[thread overview]
Message-ID: <CABBYNZJtyHLv-WR4P3Hda+A3=BT6rttK6GJCKZ2LieXarwmbew@mail.gmail.com> (raw)
In-Reply-To: <1456322258-28742-1-git-send-email-john@metanate.com>

Hi John,

On Wed, Feb 24, 2016 at 3:57 PM, John Keeping <john@metanate.com> wrote:
> Commit 101b439 (tools/avinfo: Add partial support for Sony LDAC) added a
> new a2dp_ldac_t structure but only inside a little endian ifdef.  Add
> the same structure in the big endian code.
>
> The structure definition doesn't differ for the big/little endian cases
> but if the unknown fields are discovered in the future it might, so a
> copy is added rather than pulling the existing definition below the
> endif.
> ---
>  profiles/audio/a2dp-codecs.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/profiles/audio/a2dp-codecs.h b/profiles/audio/a2dp-codecs.h
> index e9da0bf..4fb5c0c 100644
> --- a/profiles/audio/a2dp-codecs.h
> +++ b/profiles/audio/a2dp-codecs.h
> @@ -234,6 +234,11 @@ typedef struct {
>         uint8_t channel_mode:4;
>  } __attribute__ ((packed)) a2dp_aptx_t;
>
> +typedef struct {
> +       a2dp_vendor_codec_t info;
> +       uint8_t unknown[2];
> +} __attribute__ ((packed)) a2dp_ldac_t;
> +
>  #else
>  #error "Unknown byte order"
>  #endif
> --
> 2.7.0.226.gfe986fe

Applied, thanks.

-- 
Luiz Augusto von Dentz

      reply	other threads:[~2016-02-26 12:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 13:57 [PATCH] tools/avinfo: fix big endian build John Keeping
2016-02-26 12:03 ` Luiz Augusto von Dentz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABBYNZJtyHLv-WR4P3Hda+A3=BT6rttK6GJCKZ2LieXarwmbew@mail.gmail.com' \
    --to=luiz.dentz@gmail.com \
    --cc=andrzej.kaczmarek@codecoup.pl \
    --cc=john@metanate.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).