* [PATCH] tools/avinfo: fix big endian build
@ 2016-02-24 13:57 John Keeping
2016-02-26 12:03 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 2+ messages in thread
From: John Keeping @ 2016-02-24 13:57 UTC (permalink / raw)
To: linux-bluetooth; +Cc: John Keeping, Andrzej Kaczmarek
Commit 101b439 (tools/avinfo: Add partial support for Sony LDAC) added a
new a2dp_ldac_t structure but only inside a little endian ifdef. Add
the same structure in the big endian code.
The structure definition doesn't differ for the big/little endian cases
but if the unknown fields are discovered in the future it might, so a
copy is added rather than pulling the existing definition below the
endif.
---
profiles/audio/a2dp-codecs.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/profiles/audio/a2dp-codecs.h b/profiles/audio/a2dp-codecs.h
index e9da0bf..4fb5c0c 100644
--- a/profiles/audio/a2dp-codecs.h
+++ b/profiles/audio/a2dp-codecs.h
@@ -234,6 +234,11 @@ typedef struct {
uint8_t channel_mode:4;
} __attribute__ ((packed)) a2dp_aptx_t;
+typedef struct {
+ a2dp_vendor_codec_t info;
+ uint8_t unknown[2];
+} __attribute__ ((packed)) a2dp_ldac_t;
+
#else
#error "Unknown byte order"
#endif
--
2.7.0.226.gfe986fe
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tools/avinfo: fix big endian build
2016-02-24 13:57 [PATCH] tools/avinfo: fix big endian build John Keeping
@ 2016-02-26 12:03 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2016-02-26 12:03 UTC (permalink / raw)
To: John Keeping; +Cc: linux-bluetooth@vger.kernel.org, Andrzej Kaczmarek
Hi John,
On Wed, Feb 24, 2016 at 3:57 PM, John Keeping <john@metanate.com> wrote:
> Commit 101b439 (tools/avinfo: Add partial support for Sony LDAC) added a
> new a2dp_ldac_t structure but only inside a little endian ifdef. Add
> the same structure in the big endian code.
>
> The structure definition doesn't differ for the big/little endian cases
> but if the unknown fields are discovered in the future it might, so a
> copy is added rather than pulling the existing definition below the
> endif.
> ---
> profiles/audio/a2dp-codecs.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/profiles/audio/a2dp-codecs.h b/profiles/audio/a2dp-codecs.h
> index e9da0bf..4fb5c0c 100644
> --- a/profiles/audio/a2dp-codecs.h
> +++ b/profiles/audio/a2dp-codecs.h
> @@ -234,6 +234,11 @@ typedef struct {
> uint8_t channel_mode:4;
> } __attribute__ ((packed)) a2dp_aptx_t;
>
> +typedef struct {
> + a2dp_vendor_codec_t info;
> + uint8_t unknown[2];
> +} __attribute__ ((packed)) a2dp_ldac_t;
> +
> #else
> #error "Unknown byte order"
> #endif
> --
> 2.7.0.226.gfe986fe
Applied, thanks.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-26 12:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-24 13:57 [PATCH] tools/avinfo: fix big endian build John Keeping
2016-02-26 12:03 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).