linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Patrik Flykt <patrik.flykt@linux.intel.com>
Cc: "linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	Alexander Aring <aar@pengutronix.de>,
	Jukka Rissanen <jukka.rissanen@linux.intel.com>
Subject: Re: [RFC 1/4] addrconf: Create EUI48 IPv6 addresses for BTLE 6LoWPAN
Date: Tue, 22 Nov 2016 14:26:16 +0200	[thread overview]
Message-ID: <CABBYNZKFnwzgR7mp5qOqibvqZjF3tfTcDB-+LsNkPwcYVPvrKw@mail.gmail.com> (raw)
In-Reply-To: <1466408993-3808-2-git-send-email-patrik.flykt@linux.intel.com>

Hi,

On Mon, Jun 20, 2016 at 10:49 AM, Patrik Flykt
<patrik.flykt@linux.intel.com> wrote:
> Create EUI48 IPv6 addresses for 6LoWPAN over Bluetooth Low Energy.
> Both IEEE802.15.4 and Bluetooth Low Energy use a netdevice type of
> ARPHRD_6LOWPAN, therefore generate the IPv6 address based on the
> MAC address length.
>
> Signed-off-by: Patrik Flykt <patrik.flykt@linux.intel.com>
> ---
>  net/ipv6/addrconf.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 6c8fc3f..6697fe6 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -2055,6 +2055,10 @@ static int ipv6_generate_eui64(u8 *eui, struct net_device *dev)
>         case ARPHRD_IPGRE:
>                 return addrconf_ifid_gre(eui, dev);
>         case ARPHRD_6LOWPAN:
> +               /* 6LoWPAN over BTLE */
> +               if (dev->addr_len == ETH_ALEN)
> +                       return addrconf_ifid_eui48(eui, dev);
> +
>                 return addrconf_ifid_eui64(eui, dev);
>         case ARPHRD_IEEE1394:
>                 return addrconf_ifid_ieee1394(eui, dev);
> --
> 2.8.1

This still seems to be broken.

-- 
Luiz Augusto von Dentz

  reply	other threads:[~2016-11-22 12:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20  7:49 [RFC 0/4] Fix BT 6lowpan point-to-point interface Patrik Flykt
2016-06-20  7:49 ` [RFC 1/4] addrconf: Create EUI48 IPv6 addresses for BTLE 6LoWPAN Patrik Flykt
2016-11-22 12:26   ` Luiz Augusto von Dentz [this message]
2016-11-22 15:28     ` Alexander Aring
2016-06-20  7:49 ` [RFC 2/4] 6lowpan: Set MAC address lenght according to LOWPAN_LLTYPE Patrik Flykt
2016-06-20 10:46   ` Alexander Aring
2016-06-20 11:18   ` Alexander Aring
2016-06-20  7:49 ` [RFC 3/4] bluetooth: Set 6 byte device addresses Patrik Flykt
2016-06-20 11:08   ` Alexander Aring
2016-06-20  7:49 ` [RFC 4/4] bluetooth: Do not set IFF_POINTOPOINT Patrik Flykt
2016-06-20 12:56   ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABBYNZKFnwzgR7mp5qOqibvqZjF3tfTcDB-+LsNkPwcYVPvrKw@mail.gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=aar@pengutronix.de \
    --cc=jukka.rissanen@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=patrik.flykt@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).