linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH BlueZ] tools/obexctl: Fix display of size/time during transfer
@ 2017-11-29  8:29 ERAMOTO Masaya
  2017-12-04 12:21 ` Luiz Augusto von Dentz
  0 siblings, 1 reply; 2+ messages in thread
From: ERAMOTO Masaya @ 2017-11-29  8:29 UTC (permalink / raw)
  To: linux-bluetooth@vger.kernel.org

When obexctl is run after starting to transfer a file, the transferred
size and the remaining time will be extreme values first as below:

  [NEW] Transfer /org/bluez/obex/server/session8/transfer6
  [CHG] Transfer /org/bluez/obex/server/session8/transfer6 Transferred: 1670741 (@1670KB/s 03:52)
  [CHG] Transfer /org/bluez/obex/server/session8/transfer6 Transferred: 1703502 (@32KB/s 197:14)
  [CHG] Transfer /org/bluez/obex/server/session8/transfer6 Transferred: 1736263 (@32KB/s 197:13)
---
 tools/obexctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/obexctl.c b/tools/obexctl.c
index ece50f682..33ee180a3 100644
--- a/tools/obexctl.c
+++ b/tools/obexctl.c
@@ -2319,7 +2319,7 @@ static void transfer_added(GDBusProxy *proxy)
 
 	data = g_new0(struct transfer_data, 1);
 
-	if (g_dbus_proxy_get_property(proxy, "Transfered", &iter))
+	if (g_dbus_proxy_get_property(proxy, "Transferred", &iter))
 		dbus_message_iter_get_basic(&iter, &data->transferred);
 
 	if (g_dbus_proxy_get_property(proxy, "Size", &iter))
-- 
2.14.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH BlueZ] tools/obexctl: Fix display of size/time during transfer
  2017-11-29  8:29 [PATCH BlueZ] tools/obexctl: Fix display of size/time during transfer ERAMOTO Masaya
@ 2017-12-04 12:21 ` Luiz Augusto von Dentz
  0 siblings, 0 replies; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2017-12-04 12:21 UTC (permalink / raw)
  To: ERAMOTO Masaya; +Cc: linux-bluetooth@vger.kernel.org

Hi Eramoto,

On Wed, Nov 29, 2017 at 10:29 AM, ERAMOTO Masaya
<eramoto.masaya@jp.fujitsu.com> wrote:
> When obexctl is run after starting to transfer a file, the transferred
> size and the remaining time will be extreme values first as below:
>
>   [NEW] Transfer /org/bluez/obex/server/session8/transfer6
>   [CHG] Transfer /org/bluez/obex/server/session8/transfer6 Transferred: 1670741 (@1670KB/s 03:52)
>   [CHG] Transfer /org/bluez/obex/server/session8/transfer6 Transferred: 1703502 (@32KB/s 197:14)
>   [CHG] Transfer /org/bluez/obex/server/session8/transfer6 Transferred: 1736263 (@32KB/s 197:13)
> ---
>  tools/obexctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/obexctl.c b/tools/obexctl.c
> index ece50f682..33ee180a3 100644
> --- a/tools/obexctl.c
> +++ b/tools/obexctl.c
> @@ -2319,7 +2319,7 @@ static void transfer_added(GDBusProxy *proxy)
>
>         data = g_new0(struct transfer_data, 1);
>
> -       if (g_dbus_proxy_get_property(proxy, "Transfered", &iter))
> +       if (g_dbus_proxy_get_property(proxy, "Transferred", &iter))
>                 dbus_message_iter_get_basic(&iter, &data->transferred);
>
>         if (g_dbus_proxy_get_property(proxy, "Size", &iter))
> --
> 2.14.1

Applied, thanks.

-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-12-04 12:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-29  8:29 [PATCH BlueZ] tools/obexctl: Fix display of size/time during transfer ERAMOTO Masaya
2017-12-04 12:21 ` Luiz Augusto von Dentz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).