linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Syam Sidhardhan <s.syam@samsung.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd] client: fix parsing of apparam on pbap driver
Date: Mon, 16 Jan 2012 17:02:32 +0200	[thread overview]
Message-ID: <CABBYNZKqWnHF_robALXuke2LDN3z0rB10fY4iF_rRGyJcFCrMw@mail.gmail.com> (raw)
In-Reply-To: <895415989D644B5AB712230EEFE0904B@sisodomain.com>

Hi Syam,

On Mon, Jan 16, 2012 at 4:52 PM, Syam Sidhardhan <s.syam@samsung.com> wrote:
> Here one more changes is required. Since we are not updating the size
> while (size > APPARAM_HDR_SIZE) statement will always evaluate as false
> and it will never enter into the loop. So we need to have a statement
> size = params.size; before checking for the while() condition. Correct me if
> I 'm wrong here.

Yep, gonna fix that too, thanks for the feedback.


-- 
Luiz Augusto von Dentz

  reply	other threads:[~2012-01-16 15:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-14  9:53 [PATCH obexd] client: fix parsing of apparam on pbap driver Luiz Augusto von Dentz
2012-01-16 14:52 ` Syam Sidhardhan
2012-01-16 15:02   ` Luiz Augusto von Dentz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-01-17 10:15 Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABBYNZKqWnHF_robALXuke2LDN3z0rB10fY4iF_rRGyJcFCrMw@mail.gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=s.syam@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).