From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd] build: Fix libbluetooth dependency
Date: Thu, 8 Mar 2012 11:28:34 +0200 [thread overview]
Message-ID: <CABBYNZKvv-+FLNHoOr7M6by9MS+aChsDigZEjoL2x=5pGskhiQ@mail.gmail.com> (raw)
In-Reply-To: <1331147816.3392.182.camel@aeonflux>
Hi Marcel,
On Wed, Mar 7, 2012 at 9:16 PM, Marcel Holtmann <marcel@holtmann.org> wrote=
:
> Hi Luiz,
>
>> Building with libbluetooth prior to 4.99 cause an error:
>>
>> btio/btio.c: In function 'get_key_size':
>> btio/btio.c:522:14: error: 'struct bt_security' has no member named 'key=
_size
>>
>> Thanks to Bastien Nocera for reporting it.
>> ---
>> =A0configure.ac | =A0 =A04 ++--
>> =A01 files changed, 2 insertions(+), 2 deletions(-)
>
> I rather not have this patch included since it makes things complicated
> for people to build this. Copying over just the header is good enough to
> fix this.
I would agree if we do static linking the whole libbluetooth, but just
a header IMO that is asking for trouble e.g. it could still cause
linking problems due to missing implementation or even crashes.
Maybe we should think more seriously about moving obexd inside BlueZ.
--=20
Luiz Augusto von Dentz
prev parent reply other threads:[~2012-03-08 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 11:11 [PATCH obexd] build: Fix libbluetooth dependency Luiz Augusto von Dentz
2012-03-07 19:16 ` Marcel Holtmann
2012-03-08 9:28 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABBYNZKvv-+FLNHoOr7M6by9MS+aChsDigZEjoL2x=5pGskhiQ@mail.gmail.com' \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).