linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Gowtham Anandha Babu <gowtham.ab@samsung.com>
Cc: "linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	Dmitry Kasatkin <d.kasatkin@samsung.com>,
	Bharat Panda <bharat.panda@samsung.com>,
	cpgs@samsung.com
Subject: Re: [PATCH] plugins/autopair: Provide descriptive error log
Date: Tue, 25 Nov 2014 23:51:31 +0200	[thread overview]
Message-ID: <CABBYNZLgBR_b-wzC+ZKuOxmhJnz4j5yo69FCvzw2fah7D+EhGw@mail.gmail.com> (raw)
In-Reply-To: <001901d00890$32d6b8b0$98842a10$@samsung.com>

Hi,

On Tue, Nov 25, 2014 at 11:14 AM, Gowtham Anandha Babu
<gowtham.ab@samsung.com> wrote:
> Hi,
>
>> -----Original Message-----
>> From: Gowtham Anandha Babu [mailto:gowtham.ab@samsung.com]
>> Sent: Friday, November 21, 2014 2:19 PM
>> To: linux-bluetooth@vger.kernel.org
>> Cc: d.kasatkin@samsung.com; bharat.panda@samsung.com;
>> cpgs@samsung.com; Gowtham Anandha Babu
>> Subject: [PATCH] plugins/autopair: Provide descriptive error log
>>
>> Add more description in error logging.
>> ---
>>  plugins/autopair.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/plugins/autopair.c b/plugins/autopair.c index
> d63da93..43b0e00
>> 100644
>> --- a/plugins/autopair.c
>> +++ b/plugins/autopair.c
>> @@ -172,8 +172,8 @@ static int autopair_init(void)
>>       n = read(fd, &seed, sizeof(seed));
>>       if (n < (ssize_t) sizeof(seed)) {
>>               err = (n == -1) ? -errno : -EIO;
>> -             error("Failed to read %zu bytes from /dev/urandom",
>> -
> sizeof(seed));
>> +             error("Failed to read %zu bytes from /dev/urandom: %s
>> (%d)",
>> +                                     sizeof(seed), strerror(-err), -err);
>>               close(fd);
>>               return err;
>>       }
>> --
>> 1.9.1
>
> Ping.

Applied, thanks.


-- 
Luiz Augusto von Dentz

  reply	other threads:[~2014-11-25 21:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-21  8:49 [PATCH] tools/sdptool: Add support for MAP service Gowtham Anandha Babu
2014-11-21  8:49 ` [PATCH] plugins/autopair: Provide descriptive error log Gowtham Anandha Babu
2014-11-25  9:14   ` Gowtham Anandha Babu
2014-11-25 21:51     ` Luiz Augusto von Dentz [this message]
2014-11-25  9:14 ` [PATCH] tools/sdptool: Add support for MAP service Gowtham Anandha Babu
2014-11-25 21:52   ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABBYNZLgBR_b-wzC+ZKuOxmhJnz4j5yo69FCvzw2fah7D+EhGw@mail.gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=bharat.panda@samsung.com \
    --cc=cpgs@samsung.com \
    --cc=d.kasatkin@samsung.com \
    --cc=gowtham.ab@samsung.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).