From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: ERAMOTO Masaya <eramoto.masaya@jp.fujitsu.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ] obexd: Clean up unneeded list in src/obex.c
Date: Tue, 23 Jan 2018 15:42:16 -0200 [thread overview]
Message-ID: <CABBYNZLxGhTmYda3uVFAnErdiUUFmX3vKvVG7a0WJjN6RgSGnA@mail.gmail.com> (raw)
In-Reply-To: <1f42874f-efcf-f50c-ef2b-a9b709d93db4@jp.fujitsu.com>
Hi Eramoto,
On Tue, Jan 23, 2018 at 7:45 AM, ERAMOTO Masaya
<eramoto.masaya@jp.fujitsu.com> wrote:
> Cleans up the sessions list which has been unneeded by commit 8572afb4
> ("obexd: Make use of transport drivers and some cleanups").
> ---
> obexd/src/obex.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/obexd/src/obex.c b/obexd/src/obex.c
> index 308e56d07..a4bae857f 100644
> --- a/obexd/src/obex.c
> +++ b/obexd/src/obex.c
> @@ -54,8 +54,6 @@
> #include "service.h"
> #include "transport.h"
>
> -static GSList *sessions = NULL;
> -
> typedef struct {
> uint8_t version;
> uint8_t flags;
> @@ -233,8 +231,6 @@ static void os_reset_session(struct obex_session *os)
>
> static void obex_session_free(struct obex_session *os)
> {
> - sessions = g_slist_remove(sessions, os);
> -
> if (os->io) {
> g_io_channel_shutdown(os->io, TRUE, NULL);
> g_io_channel_unref(os->io);
> @@ -1067,8 +1063,6 @@ int obex_session_start(GIOChannel *io, uint16_t tx_mtu, uint16_t rx_mtu,
> obex_getsockname(os, &os->src);
> obex_getpeername(os, &os->dst);
>
> - sessions = g_slist_prepend(sessions, os);
> -
> return 0;
> }
>
> --
> 2.14.1
Applied, thanks.
--
Luiz Augusto von Dentz
prev parent reply other threads:[~2018-01-23 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 9:45 [PATCH BlueZ] obexd: Clean up unneeded list in src/obex.c ERAMOTO Masaya
2018-01-23 17:42 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABBYNZLxGhTmYda3uVFAnErdiUUFmX3vKvVG7a0WJjN6RgSGnA@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=eramoto.masaya@jp.fujitsu.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).