linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Santiago Carot <sancane@gmail.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 3/3] thermometer: Fix re-enabling notification/indication on reconnection
Date: Wed, 15 Feb 2012 10:03:40 +0100	[thread overview]
Message-ID: <CACLukzLJc7GO3TP9mU5MrY2SmPLG7c9figWNxJP5KuK286DD8g@mail.gmail.com> (raw)
In-Reply-To: <1329241945-32414-3-git-send-email-anderson.lizardo@openbossa.org>

Hi Anderson,

2012/2/14 Anderson Lizardo <anderson.lizardo@openbossa.org>:
> If a result callback is not specified for gatt_write_char() it is
> assumed that Write Command will be used. This is not valid for
> Characteristic Descriptors, which only support Write Request.

I'm not against this patch but from my point of view, I think this is
a little obscure behaviour wich would deserve an advice coment in
gatt.h due it isn't clear for anybody developping over GATT to guess
it. On the other hand, _I remember another functions in gatt.h wich
have similar double behaviour depending on the parameters provided in
there, suach as gatt_discovery_primary, in wich a discover ALL primary
service is done if the uuid is equal to NULL or disvovery service by
UUID is done if uuid is provided, I think gatt_discover_char works in
the same way. Maybe that having a good comments here could help to
avoid this kind of errors in the future.

Regards.
Santiago

  reply	other threads:[~2012-02-15  9:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-14 17:52 [PATCH BlueZ 1/3] thermometer: Fix device driver probe Anderson Lizardo
2012-02-14 17:52 ` [PATCH BlueZ 2/3] thermometer: Fix handling of missing Temperature Type Anderson Lizardo
2012-02-15  8:50   ` Santiago Carot
2012-02-15 10:41     ` Anderson Lizardo
2012-02-15 11:06       ` Santiago Carot
2012-02-15 11:53         ` Anderson Lizardo
2012-02-15 12:49         ` Anderson Lizardo
2012-02-14 17:52 ` [PATCH BlueZ 3/3] thermometer: Fix re-enabling notification/indication on reconnection Anderson Lizardo
2012-02-15  9:03   ` Santiago Carot [this message]
2012-02-15 10:44     ` Anderson Lizardo
2012-02-15 12:38 ` [PATCH v2 BlueZ 1/3] thermometer: Fix device driver probe Anderson Lizardo
2012-02-15 12:38   ` [PATCH v2 BlueZ 2/3] thermometer: Fix handling of missing Temperature Type Anderson Lizardo
2012-02-15 12:38   ` [PATCH v2 BlueZ 3/3] thermometer: Fix re-enabling notification/indication on reconnection Anderson Lizardo
2012-02-16 13:13   ` [PATCH v2 BlueZ 1/3] thermometer: Fix device driver probe Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACLukzLJc7GO3TP9mU5MrY2SmPLG7c9figWNxJP5KuK286DD8g@mail.gmail.com \
    --to=sancane@gmail.com \
    --cc=anderson.lizardo@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).