From: Anderson Lizardo <anderson.lizardo@openbossa.org>
To: Santiago Carot-Nemesio <sancane@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 6/6] Notify intermediate measurements
Date: Wed, 9 Nov 2011 08:17:24 -0400 [thread overview]
Message-ID: <CAJdJm_OYkodB5ChynpfD6ALzKW7xWq30F-TZwGuE19QWu8TZGQ@mail.gmail.com> (raw)
In-Reply-To: <1320835923-10989-7-git-send-email-sancane@gmail.com>
Hi Santiago,
On Wed, Nov 9, 2011 at 6:52 AM, Santiago Carot-Nemesio
<sancane@gmail.com> wrote:
> static void recv_measurement(struct thermometer *t, struct measurement *msmt)
> {
> - GSList *l;
> + GSList *l, *ll;
>
> - if (g_strcmp0(msmt->msmnt, "Intermediate") == 0) {
> - DBG("Notification of intermediate measurement not implemented");
> - return;
> - }
> + if (g_strcmp0(msmt->msmnt, "Intermediate") == 0)
> + ll = t->iwatchers;
> + else
> + ll = t->fwatchers;
>
> - for (l = t->fwatchers; l; l = l->next)
> + for (l = ll; l; l = l->next)
> update_watcher(l->data, msmt);
> }
What about using g_slist_foreach() above? Also "ll" seems too generic,
what about "wlist".
Regards,
--
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
next prev parent reply other threads:[~2011-11-09 12:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 10:51 Health Thermometer Profile (HTP) Santiago Carot-Nemesio
2011-11-09 10:51 ` [PATCH 1/6] Manage GATT attribute indications in handle callback Santiago Carot-Nemesio
2011-11-09 10:51 ` [PATCH 2/6] Parse final measurement indication Santiago Carot-Nemesio
2011-11-09 10:52 ` [PATCH 3/6] Add org.bluez.ThermometerWatcher interface to default policy Santiago Carot-Nemesio
2011-11-09 10:52 ` [PATCH 4/6] Implement EnableIntermediateMeasurement D-Bus method Santiago Carot-Nemesio
2011-11-09 10:52 ` [PATCH 5/6] Implement DisableIntermediateMeasurement " Santiago Carot-Nemesio
2011-11-09 10:52 ` [PATCH 6/6] Notify intermediate measurements Santiago Carot-Nemesio
2011-11-09 12:17 ` Anderson Lizardo [this message]
2011-11-09 14:49 ` Santiago Carot
2011-11-09 12:00 ` [PATCH 1/6] Manage GATT attribute indications in handle callback Anderson Lizardo
2011-11-09 12:54 ` Hendrik Sattler
2011-11-09 13:30 ` Anderson Lizardo
2011-11-09 13:53 ` Hendrik Sattler
2011-11-09 14:17 ` Anderson Lizardo
2011-11-09 14:44 ` Santiago Carot
2011-11-09 15:40 ` Anderson Lizardo
2011-11-09 16:50 ` Santiago Carot
2011-11-09 12:19 ` Health Thermometer Profile (HTP) Anderson Lizardo
2011-11-09 14:03 ` Santiago Carot
-- strict thread matches above, loose matches on Subject: below --
2011-11-10 11:36 Santiago Carot-Nemesio
2011-11-10 11:36 ` [PATCH 1/6] Manage GATT attribute indications in handle callback Santiago Carot-Nemesio
2011-11-10 11:36 ` [PATCH 2/6] Parse final measurement indication Santiago Carot-Nemesio
2011-11-10 11:36 ` [PATCH 3/6] Add org.bluez.ThermometerWatcher interface to default policy Santiago Carot-Nemesio
2011-11-10 11:37 ` [PATCH 4/6] Implement EnableIntermediateMeasurement D-Bus method Santiago Carot-Nemesio
2011-11-10 11:37 ` [PATCH 5/6] Implement DisableIntermediateMeasurement " Santiago Carot-Nemesio
2011-11-10 11:37 ` [PATCH 6/6] Notify intermediate measurements Santiago Carot-Nemesio
2011-11-14 12:11 Health Thermometer Profile (HTP) Santiago Carot-Nemesio
2011-11-14 12:11 ` [PATCH 1/6] Manage GATT attribute indications in handle callback Santiago Carot-Nemesio
2011-11-14 12:11 ` [PATCH 2/6] Parse final measurement indication Santiago Carot-Nemesio
2011-11-14 12:11 ` [PATCH 3/6] Add org.bluez.ThermometerWatcher interface to default policy Santiago Carot-Nemesio
2011-11-14 12:11 ` [PATCH 4/6] Implement EnableIntermediateMeasurement D-Bus method Santiago Carot-Nemesio
2011-11-14 12:11 ` [PATCH 5/6] Implement DisableIntermediateMeasurement " Santiago Carot-Nemesio
2011-11-14 12:11 ` [PATCH 6/6] Notify intermediate measurements Santiago Carot-Nemesio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJdJm_OYkodB5ChynpfD6ALzKW7xWq30F-TZwGuE19QWu8TZGQ@mail.gmail.com \
--to=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sancane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).