From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
To: Michal Labedzki <michal.labedzki@tieto.com>
Cc: linux-bluetooth@vger.kernel.org,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Subject: Re: [PATCH 2/3] avrcp: Add error code for rejected vendor command
Date: Fri, 2 Mar 2012 13:59:34 -0300 [thread overview]
Message-ID: <CAMOw1v6pNC7eebGEAMLEWKNJ8NaR2aUweigMCEzbG5_0wgkUTA@mail.gmail.com> (raw)
In-Reply-To: <20120302093917.GB27242@uw000554.eu.tieto.com>
On Fri, Mar 2, 2012 at 6:39 AM, Michal Labedzki
<michal.labedzki@tieto.com> wrote:
> On Thu, Mar 01, 2012 at 05:34:19PM +0200, Luiz Augusto von Dentz wrote:
>> Hi Michal,
>>
>> On Thu, Mar 1, 2012 at 4:45 PM, Michal Labedzki
>> <michal.labedzki@tieto.com> wrote:
>> > Make correct response for any vendor commands when there are not any
>> > registered player. According to the specification responses should be
>> > REJECTED with error code.
>>
>> Please quote the spec whenever possible, actually what spec does this come from?
>>
>>
>> --
>> Luiz Augusto von Dentz
>
> Hi Luiz,
>
> Here you are:
> "For error response PDU the response parameter is always the error code independent
> of the response format defined for ACCEPTED PDU response for the corresponding
> PDU command."
> (source: AVRCP 1.3 specification, pages 34,56 or AVRCP 1.4 specification, pages 33,93)
Ack.
Could you put this in the commit message?
Lucas De Marchi
next prev parent reply other threads:[~2012-03-02 16:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 14:45 [PATCH 1/3] avrcp: Fix response ctype of AbortContinuingResponse Michal Labedzki
2012-03-01 14:45 ` [PATCH 2/3] avrcp: Add error code for rejected vendor command Michal Labedzki
2012-03-01 15:34 ` Luiz Augusto von Dentz
2012-03-02 9:39 ` Michal Labedzki
2012-03-02 16:59 ` Lucas De Marchi [this message]
2012-03-07 16:23 ` [PATCH v3] " Michal Labedzki
2012-03-13 11:51 ` Johan Hedberg
2012-03-01 14:45 ` [PATCH 3/3] avrcp: Treat position as unknown when duration is unavailable Michal Labedzki
2012-03-01 15:43 ` Luiz Augusto von Dentz
2012-03-02 21:31 ` Lucas De Marchi
2012-03-07 16:35 ` Michal Labedzki
2012-03-01 15:50 ` [PATCH 1/3] avrcp: Fix response ctype of AbortContinuingResponse Luiz Augusto von Dentz
2012-03-02 17:16 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMOw1v6pNC7eebGEAMLEWKNJ8NaR2aUweigMCEzbG5_0wgkUTA@mail.gmail.com \
--to=lucas.demarchi@profusion.mobi \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=michal.labedzki@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).